search

Dao-AILab / causal-conv1d

Causal depthwise conv1d in CUDA, with a PyTorch interface
BSD 3-Clause "New" or "Revised" License
332 stars 61 forks source link

Enable this to build with build isolation on #26

Open kszlim opened 5 months ago

kszlim commented 5 months ago

Now if i pip install this package or uv pip install it, it will work, should also close https://github.com/Dao-AILab/causal-conv1d/issues/24 i believe also should close https://github.com/Dao-AILab/causal-conv1d/issues/2.

Tests all passed too.

kszlim commented 5 months ago

I noticed you mentioned: https://github.com/Dao-AILab/causal-conv1d/pull/5#issuecomment-1919965990

But i believe if you already have torch, because there's no version specified in the build requirement, it will just use whatever is in your env (unless it's incompatible with the other build requirements, in which case the resolver should get you a compatible version of torch).

kszlim commented 5 months ago

@tridao sorry, I realize this is a drive by pr, but is it something you'll consider or should I close it?

riZZZhik commented 3 months ago

@tridao Hi,

Can you approve this pr? It actually fixes installation issues with this library

btw @kszlim thanks, good work!

yubofredwang commented 2 months ago

bump on this. Can someone pick up this PR?