Fixing missing dependency preventing it to be installed

Dao-AILab / causal-conv1d

Causal depthwise conv1d in CUDA, with a PyTorch interface

BSD 3-Clause "New" or "Revised" License

335 stars 61 forks source link

Fixing missing dependency preventing it to be installed #3

Closed havietisov closed 11 months ago

havietisov commented 11 months ago

buildtools is actually required for this to be installed. In environments that don't have buildtools, following error is encountered : https://github.com/Dao-AILab/causal-conv1d/issues/2#issuecomment-1845562938

tridao commented 11 months ago

Thanks @havietisov!

prescod commented 11 months ago

I am skeptical about the pull request. It changes line 258 of setup.py, but the crash happens when Python tries to run lines 8, 11 and 18.

Instead, I made a pyproject.toml with this content:

[build-system]
requires = ["packaging", "torch", "setuptools", "wheel"]

This seems to install the four requirements before running setup.py.

havietisov commented 11 months ago

I just tried it and yes, @prescod, you're correct, it doesn't work when packaging is not installed. My request was motivated by shenanigans caused by missing "buildtools" due to which, somehow, this thing complained about missing "packaging" in environments, when "packaging" was present.