search

Dao-AILab / causal-conv1d

Causal depthwise conv1d in CUDA, with a PyTorch interface
BSD 3-Clause "New" or "Revised" License
335 stars 61 forks source link

setup.py crashes if `bare_metal_version` is unassigned because `CUDA_HOME` is None #6

Open prescod opened 11 months ago

prescod commented 11 months ago

https://github.com/Dao-AILab/causal-conv1d/blob/acf67c469baeacd93708783eeb1d125ee176de24/setup.py#L112

This line crashes if bare_metal_version is unassigned.

bare_metal_version is unassigned if CUDA_HOME is None.

https://github.com/Dao-AILab/causal-conv1d/blob/acf67c469baeacd93708783eeb1d125ee176de24/setup.py#L100-L101

Since this package may be a dependency of other packages (like Mamba-Chat), it might be good to give a clear error message that it is failing due to lack of CUDA availability. I didn't know when I installed Mamba-Chat that it would only work on Nvidia.

not-lain commented 7 months ago

same for me (i'm on windows) https://github.com/Dao-AILab/causal-conv1d/blob/3db8befd65b7ceb954a414d29ecb6f636b224af4/setup.py#L60