search

Daohub-io / cap9

Capability-based security protocol for smart contracts
Apache License 2.0
22 stars 10 forks source link

Implement the WRITE syscall #169

Closed JakeOShannessy closed 5 years ago

JakeOShannessy commented 5 years ago

This implements the WRITE syscall as per #140. This does not currently perform any checking of capabilities, but does include many lower level changes to get syscalls working in general.

JakeOShannessy commented 5 years ago

It doesn't do capability checking, but I think we should merge earlier rather than later and do checking in another step. This is mainly because with this PR comes a lot of low level work that was necessary for syscalls in general.

JakeOShannessy commented 5 years ago

I added an extra commit from the new branch I'm working on to fix a slight serialization/deserialization error.

JakeOShannessy commented 5 years ago

Yep, as I did that I was thinking about the structure as well, but came to a similar to conclusion. At least we have an abstraction and we can sort those issues out underneath.

At the very least those traits should not come from the validator module. Let's make an issue for it.