search

Daomephsta / LootTweaker

A CraftTweaker addon that adds the ability to tweak loot tables
MIT License
17 stars 2 forks source link

Crash on entering world #70

Closed NielsPilgaard closed 4 years ago

NielsPilgaard commented 4 years ago

Describe the bug Crash on entering world.

To Reproduce Steps to reproduce the behavior:

Expected behavior No crash.

Logs & scripts Crash: https://pastebin.com/EhxRmvGf CraftTweakerLog: https://gist.github.com/NillerMedDild/99ad8bc0fe1dcd4c01655fb5afe1014d Script used: https://gist.github.com/NillerMedDild/e0202f1bc0455c9eabec6f9d8e7fc61e

Version Info (Exact versions only): LootTweaker: 0.1.5+MC1.12.2 CraftTweaker/Minetweaker: 1.12-4.1.19 Forge: 1.12.2-14.23.5.2847 Minecraft: 1.12.2

Additional context I believe this crash only happens when near a loot chest.

Daomephsta commented 4 years ago

I downloaded E2E 1.76 & tried to reproduce this with spawned in chests using the loot tables your script modifies, as well as some structure chests I found (mineshaft, AS fountain, and quark pirate ship). Neither getting near to, nor opening any of them caused a crash. They all worked as I expected them to.

Daomephsta commented 4 years ago

I tried reloading the world while near a test chest, then opening it; as well as switching to another world and back while near a test chest, then opening it. Neither reproduced the crash.

I'll need you to narrow down the reproduction criteria before I can do anything more.

NielsPilgaard commented 4 years ago

Alright, thanks for testing - I'll just close this since it can't be reproduced :)

Daomephsta commented 4 years ago

Reopening because I've got 2 other reports of this issue. Something's up.

Dakedres commented 4 years ago

Same issue here when running Rebirth of The Night with some extra mods (and some removed, namely Ice and Fire). I note that because the unmodified version does not crash. This leads me to believe it's some issue between LootTweaker and another mod, and if it is, it might be worthwhile to investigate which mods are shared between all of the instances of this happening.

Modlist (ripped from the crash log because lazy) Mods Added/Removed

Note that any recipes in the pack refrencing items that don't exist anymore (due to some mods being removed) have been fixed, yes, I'm sure, I've checked it several times over.

Daomephsta commented 4 years ago

Please reproduce the issue with this debug build, it'll crash differently and spit out a CT error. These will help me find the source of the issue.

Daomephsta commented 4 years ago

@Dakedres @NillerMedDild Had any time to test with the debug build? I'd really like to get this fixed. It's clearly a problem, but I currently have no idea why what's happening is happening.

NielsPilgaard commented 4 years ago

I'm afraid not, no :/

A-bac commented 4 years ago

Seems to be working for me with the debug build, thanks

Daomephsta commented 4 years ago

@frenzye The debug build doesn't fix anything, it makes the error more informative for me.

Daomephsta commented 4 years ago

Encountered this issue while debugging another. I was finally able to debug and fix it.

NielsPilgaard commented 4 years ago

Awesome, thanks!