Dar9586 / NClientV2

An unofficial NHentai android client
Apache License 2.0
1.82k stars 95 forks source link

Volume Keys Messing With Background Media Playing #475

Open Kurrode opened 2 years ago

Kurrode commented 2 years ago

Your issue may already be reported! Please search on the issue tracker before creating one.

Expected Behavior

With "Change page with volume buttons" option enabled, you're able to listen to media and navigate pages (music, etc...) in the background without the volume keys messing with the media.

Current Behavior

While using the volume keys to navigate, the media icon pops up (In xiaomi phones, that's the icon that allows you to adjust volumes for different apps at the same time, pic attached).

Possible Solution

-When you're in full view (no top and bottom bars) you navigate pages with anything popping up. Example:

Full view

-When you're not in full view (top an bottom bars present) hitting the volume keys will adjust the volume. Example:

Not Full View

Steps to Reproduce (for bugs)

I'm not sure whether it's a bug or not, but:

1.Open any gallery with the "Change page with volume buttons" toggled on.

2.Use volume keys to change pages.

Context

Volume keys are basically the only navigation method I use and it's quite annoying to have that thingy pop up. In older versions there even was the full volume bar.

The behavior suggested above is the one present in Tachiyomi and it's really effective.

Your Environment

Version used:

-NClientV2 2.9.7-stable-release

OS:

OS