search

Dar9586 / NClientV2

An unofficial NHentai android client
Apache License 2.0
1.82k stars 95 forks source link

Favorites won't sync #508

Open morethanhater opened 1 year ago

morethanhater commented 1 year ago

Expected Behavior

When you add some release to your fav list - it adds on serverside

Current Behavior

When you add some release to your fav list - it adds only locally, but not server-sidely.

Possible Solution

Fix may lie in API?

Steps to Reproduce (for bugs)

  1. Login to your account
  2. Mark something as favorite
  3. Reinstall app
  4. Login
  5. See, that no favorites are avalible
  6. Login on website
  7. See, that no favorites are avalible

Context

Your Environment

l2eused commented 1 year ago

Did you press star button? It has another fav button in expanded tab (3-dots button).

Basically, star button only adds to local. same as fav button in expanded tab, it's only added to the website.

l2eused commented 1 year ago

Did you press star button? It has another fav button in expanded tab (3-dots button).

Basically, star button only adds to local. same as fav button in expanded tab, it's only added to the website.

In 3-bar button (top left in home app) it has 2 fav tabs (fav galleries and online fav gallries).

morethanhater commented 1 year ago

Gosh, you are right But why would one make local fav as default? Though, that's another question.

l2eused commented 1 year ago

Gosh, you are right But why would one make local fav as default? Though, that's another question.

I think it's good feature for people who don't have account. Should they add new option to add doujin in both with 1-press button? (add to local and online with 1 press)

but I'm not dev lol

Kinuseka commented 1 year ago

I made a fork that places online-favourites button first on the menu (Shown as a star icon). Fork: here I dont think this is worthy of a PR as it is a specific issue, but this should help your case.

All I did was change the hierarchy of the icons. The "change view" will move to menu drop down now though as the positioning of these icons are based on the size of the screen.

I also have a pre-built one using my own key, but you can just also build in your own using my fork. Download: app-release.zip