Darep / middleman-kss

KSS (Knyle Style Sheets) helpers for Middleman
MIT License
19 stars 4 forks source link

Support the most recent version of Middleman #2

Closed lolmaus closed 11 years ago

lolmaus commented 11 years ago

Currently middleman-kss does not support latest middleman. Please update it to be compatible with latest middleman (3.2.x to date).

Please note that middleman-navigation is also incompatible with latest middleman. If they don't catch up, i suggest you replace it with a manually coded menu in your middleman-styleguide-template.

Darep commented 11 years ago

I looked into this last night. Looks like you can no longer use Middleman's render methods for files that are outside the project's /source directory. So, the extension fails when it tries to render the styleguide_block.html.erb. I thought of a few possible solutions:

a) create our own rendering thingie b) try to hack around the restriction c) move the styleguide_block template under /source; this means that middleman-kss users have to copy it into their project manually :(

I would love to go with option a, but I'm afraid of all the extra work that comes with doing rendering.

lolmaus commented 11 years ago

I believe it's relatively easy to process a template outside Middleman by leveraging Tilt.

But if you try and find it difficult, i suggest we dump it in favor of c) until at least one more person bumps this thread or files a feature request. Let's kiss! :heart_eyes:

When you close the four issues, i'll create my version of middleman-styleguide-template, kinda more generic one. If we make the two available as Middleman boilerplates, this will eliminate the problem of manual copypasting.

Also, middlman-kss does not bundle CSS for styling the styleguide pages. Users are supposed to write their own styles or use a boilerplate. If that's true for CSS, why shouldn't it be true for templates?

Darep commented 11 years ago

Ya, I'll see what I can get it to do. I played around with Tilt last night already :) But c) is possible, that way we get the ball atleast rolling forward.

Yeah, you have a point there with not bundling the template. But the styleguide block template is quite complex compared to CSS, and probably should remain complex. IMHO, it's not a good developer experience if you have to deal with it in the beginning :) Possibility to create your own afterwards is a must-have. Arguably, middleman-kss already has a somewhat awful developer experience ;) But I don't want to worsen it ;)

lolmaus commented 11 years ago

Okay, waiting for you to either implement a) or fall back to c).

Darep commented 11 years ago

:hammer:

Darep commented 11 years ago

Well, this was easier than I thought :) Works on my machine, atleast :)

lolmaus commented 11 years ago

Yay! Gonna test it out this weekend.

Note that middleman-styleguide-template still depends on middleman-navigation that does not support middleman 3.2.

Darep commented 11 years ago

Yeah, I just pushed a commit to the template and removed it :bomb: At some point in the future, I will see if I can fix middleman-navigation, or will start looking for an alternative, hehe