Closed silverlila closed 1 month ago
@silverlila, thanks for reporting that issue! We are super excited to see your willingness to work on it.
Consider joining our Telegram Dev Community, where we can respond faster and discuss it in detail.
Please check CONTRIBUTING.md to get the steps started. If you see how we can improve the contributing guide, please let us know 🙏
Added in v4.3.1 thanks to @silverlila
Is this a unique feature?
Is your feature request related to a problem/unavailable functionality? Please describe.
Hi,
First of all, I want to congratulate on the fantastic work that has been done with this library; it has been incredibly useful for a project i'm working on.
Current Situation Currently, the library does not offer a way to dynamically update the target and rel attributes of a link within the
LinkTool
. This limitation affects a use case where we need these attributes to be customizable for different links. Would you be willing to allow for a change where these link attributes can be dynamic?Proposed Solution
I propose modifying the existing link updating logic to include
target
andrel
props. This change will allow users to dynamically set these attributes when creating or editing links.From what I inspected in the code, this seems to be the place where we could offer the possibility to override these attributes:
DefaultToolbarRender.tsx
Screenshots
Here is a screenshot of the custom
LinkTool
component I am using, which demonstrates the need for these dynamic attributes:Do you want to work on this issue?
Yes
If "yes" to the above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
I plan to implement the proposed changes by updating the
onUpdateLink
callback to includetarget
andrel
attributes in the link properties. This will allow these attributes to be dynamically set when creating or editing links.Implementation Steps:
Copy code