search

Dariensg / Hellions-Sniffer-Plus

Apache License 2.0
4 stars 7 forks source link

Composter + vanilla friendly boats #24

Closed Treetrain1 closed 3 months ago

Treetrain1 commented 8 months ago

I changed the boats to not use copies of existing boat classes by adding stone pine to the Boat.Type enum this should improve overall mod compatibility, and should improve memory a little bit as there's not 2 entity types for the stone pine boats

VoidLeech commented 5 months ago

Have you tried testing this PR on Forge? I'm getting a crash during modloading. I'll make an issue at your fork but at the moment I don't think this PR is good to merge.

VoidLeech commented 5 months ago

@Treetrain1 I would've made an issue at your fork had they been enabled. (Which, understandly, they aren't) I'm using Prism 8.0 with Forge version 47.2.0, no other mods installed except for Sniffer+ built from your sources. I get the following logs: latest.log Additional log /w error caught by Prism, not entered in latest.log: https://mclo.gs/nnEBlkI

Treetrain1 commented 5 months ago

@Treetrain1 I would've made an issue at your fork had they been enabled. (Which, understandly, they aren't) I'm using Prism 8.0 with Forge version 47.2.0, no other mods installed except for Sniffer+ built from your sources. I get the following logs: latest.log Additional log /w error caught by Prism, not entered in latest.log: https://mclo.gs/nnEBlkI

oh sorry about that ill go check that out