search

Daripher / Auto-Leveling

Auto leveling mod for Minecraft
Other
2 stars 3 forks source link

loot modifiers apply twice? #29

Open Aceplante2 opened 7 months ago

Aceplante2 commented 7 months ago

With mods such as bumblezone and miners delight, I am getting double drops added via loot modifiers. After a long process, I have narrowed it down to your mod. It appears that they are injected twice? Also, in my log, it appears to also have been injecting most recipes twice as well, which unlike drops, isn't really an issue with recipes since either they work or they dont, but I assume these are related.

Forge 1.20.1

TelepathicGrunt commented 7 months ago

This is the issue. Trying to roll a drop on LivingEntityDropsEvent. Normally, Global Loot Modifier is more recommended for these stuff.

https://github.com/Daripher/Auto-Leveling/blob/1a82e000dd4f82dfbedfe372d1ca5afeaac44ba2/src/main/java/daripher/autoleveling/event/MobsLevelingEvents.java#L107

But GLM may be tricky to implement here. I’m gonna see what I can do on my end

TelepathicGrunt commented 7 months ago

I released a fix on my end that does some more thorough checks. Though Auto Level mod should be using Global Loot Modifiers to add loot to mob drops as LivingDropsEvent is not supposed to be used for spawning new drops.

Issue should no longer occur with \Bumblezone now