Max Health Bonus (xx%) multiple time when upgrading

[glea94]

The max health issue seems to come from the gem. On the apotheosis gem we can see the value between "[ ]" when on the other gem they are not there. And the x% max health bug only apply with those gems who don't have any values "[ ]". *i didn't get the issue with the chespate that i upraged from iron to diamond with the gem in, but i'll get the bug with the other gem if i upgrade the item and the other gem in.. thank you

[glea94]

Or is it an apotheosis bug? The bug appear from the skill tree about crafting+bonus. I've tested other gems bonus, the bug only appear with the health gem.

[glea94]

This is my passive skill tree if you need to see

[Daripher]

Are you using the latest version of Item Production Lib?

[glea94]

Sorry for not responding before, i wasn't on the game. Yes i always update everything. This is the v1.0.2a actually. I am testing to see which item this is happening on, when I pass the iron to the diamond, the multiplication is displayed several times, but when I pass the diamond to the netherite, it does not display more times, it remains normal. I have a mod that allows you to upgrade items without having to craft the diamond item for example. https://modrinth.com/mod/tinkerers-smithing Maybe a bug with this mod?

[glea94]

I just tested the upgrade from leather to iron with the gem in the socket and the display is correct, this is part of tinkerer mode, so the display multiplication only happens with boots and helmets if I upgrade them.

[glea94]

with also another gem

[glea94]

This gem doesn't show any bug.🤔

[glea94]

Tested 4 suspected gems on another item : weapon. The bug appear. So the bug will show if the item can be upgrade, so the sword, helmet and boots give the bug for those 4 gems. So this is about 4 gems in the list of all gems. The % mob experience doesn't bug

[glea94]

Sorry to disturb a lot with, but i just see something now, the gems that i have problem with are also in Passive skill tree but they are disabled with apotheosis, but it seems that the buff on those gems are the one from Passive skill tree not from apotheosis, i can see the difference on the buff on apotheosis gems when it shows [+xx] and PST don't have thoses🤔.I can't test with Adventure module false cause the game ctd at world creation. edit : tested on a fresh install with only PST and no gem bug shows up, i think i got a bug between apotheosis with the adventure=true and PST getting similar gems, because only those 4 gems bug. Maybe apotheosis load your gems and buff when he load those 4 gems from it own list. But what is more odd is that on the new game with only apotheosis and PST for test, your gems are disabled properly, i don't loot them by mining or even see them in the apotheosis tab, but on the other modpack i see them inside the apotheosis tab, they are added and enabled and cause the bug🤔

[glea94]

2 screenshots from the test with only PST and apotheosis (and all dependencies), and my mod pack with more mods, of the apotheosis tab, adventure is on on both but i can loot your gems on mining on my modpack and not on the 2 mods test.

[glea94]

This is the entire mod list where the bug shows up..🙄If you need to see something.

[✔] AdvancementPlaques-1.20.1-forge-1.5.1 -- 142 | [✔] AnimaticaReforged-1.20.1-0.1.3 143 | [✔] Apotheosis-1.20.1-7.3.0 144 | [✔] apotheotic_additions1.4.5 145 | [✔] ApothicAttributes-1.20.1-1.2.1 146 | [✔] ApothicCurios-1.20.1-1.0.3b 147 | [✔] arc-1.4.3-forge 148 | [✔] architectury-9.1.13-forge 149 | [✔] artifacts-forge-9.2.2 150 | [✔] AttributeFix-Forge-1.20.1-21.0.4 151 | [✔] AutoLeveling-1.20-1.19b 152 | [✔] balm-forge-1.20.1-7.2.1 154 | [✔] BarteringStation-v8.0.0-1.20.1-Forge 155 | [✔] BetterAnimationsCollection-v8.0.0-1.20.1-Forge 156 | [✔] betterdays-1.20.1-3.1.0.3-FORGE 157 | [✔] BOMD-Forge-1.20.1-1.1.2 158 | [✔] Bookshelf-Forge-1.20.1-20.1.9 159 | [✔] Bountiful-6.0.3 1.20.1-forge 160 | [✔] caelus-forge-3.1.0 1.20 161 | [✔] catalogue-forge-1.20.1-1.8.0 162 | [✔] CerbonsAPI-Forge-1.20.1-1.1.0 163 | [✔] chat_heads-0.10.31-forge-1.20 164 | [✔] cheaper-netherite-smithing-templates-1.0 165 | [✔] chunkloaders-1.2.8a-forge-mc1.20.1 166 | [✔] citadel-2.5.3-1.20.1 167 | [✔] citresewn-1.20.1-5 168 | [✔] cloth-config-11.1.118-forge 169 | [✔] Clumps-forge-1.20.1-12.0.0.3 170 | [✔] collective-1.20.1-7.31 171 | [✔] collective-1.20.1-7.32 172 | [✔] comforts-forge-6.3.5 1.20.1 173 | [✔] command-config-0.1.0-beta.4 1.20 174 | [✔] Connector-1.0.0-beta.36 1.20.1 175 | [✔] ConnectorExtras-1.9.3 1.20.1 176 | [✔] continuebutton-1.2.2 1.20 177 | [✔] cupboard-1.20.1-2.3 178 | [✔] curios-forge-5.7.0 1.20.1 179 | [✔] Dave's Potioneering-forge-1.20.1-11 180 | [✔] deeperdarker-forge-1.20.1-1.2.1 181 | [✔] DisenchantmentEditTable-1.20-1.1.2 182 | [✔] elytra_physics-forge-2.0 183 | [✔] elytraslot-forge-6.3.0 1.20.1 184 | [✔] elytratrims-forge-2.0.1 1.20.1 185 | [✔] embeddium-0.3.6 mc1.20.1 186 | [✔] embeddiumplus-1.20.1-v1.2.4 187 | [✔] emi-1.1.2 1.20.1 forge 188 | [✔] emiffect-forge-1.1.2 mc1.20.1 189 | [✔] emissive-plugin-1.20.1-2.0.4-forge 190 | [✔] emitrades-forge-1.2.1 mc1.20.1 191 | [✔] EnchantingInfuser-v8.0.2-1.20.1-Forge 192 | [✔] EnchantmentDescriptions-Forge-1.20.1-17.0.13 193 | [✔] entity_model_features_forge_1.20.1-1.2.3 194 | [✔] entity_texture_features_forge_1.20.1-5.2.3 195 | [✔] entityculling-forge-1.6.2-mc1.20.1 196 | [✔] EquipmentCompare-1.20.1-forge-1.3.7 197 | [✔] essential_1-3-0-6_forge_1-20-1 198 | [✔] extra_compat-1.4.3 199 | [✔] fabric-api-0.92.0 1.11.3 1.20.1 200 | [✘] farsight-1.20.1-3.6.jar (disabled) 201 | [✔] Female-Gender-Mod-forge-1.20.1-3.0.1 202 | [✔] ferritecore-6.0.1-forge 203 | [✔] followersteleporttoo-1.20.1-2.4 204 | [✔] forgeautofish-6.0.0-1.20.1 205 | [✔] ftb-library-forge-2001.1.5 206 | [✔] furnitura-1.11-1.20.1 207 | [✔] fusion-1.1.1-forge-mc1.20.1 208 | [✔] geckolib-forge-1.20.1-4.4.2 209 | [✔] gravestone-forge-1.20.1-1.0.14 210 | [✔] guardvillagers-1.20.1-1.6.4 211 | [✔] HeldItemTooltips-v8.0.0-1.20.1-Forge 212 | [✔] Iceberg-1.20.1-forge-1.1.18 213 | [✔] immersive_armors-1.6.1 1.20.1-forge 214 | [✔] InventorySorter-1.9.0-1.20 215 | [✔] inventorytotem-1.20.1-3.2 216 | [✔] ItemProductionLib-1.20.1-1.0.2a-all 217 | [✔] itemrestrictions-1.1.2 218 | [✔] Jade-1.20.1-forge-11.8.0 219 | [✔] jeed-1.20-2.1.7 220 | [✔] jei-1.20.1-forge-15.3.0.4 221 | [✔] jobsplus-1.3-forge 222 | [✔] Kambrik-6.1.1 1.20.1-forge 223 | [✔] keepcuriosinventory-1.20.1-0.0.1 224 | [✔] kotlinforforge-4.10.0-all 225 | [✔] L_Enders_Cataclysm-1.90 -1.20.1 226 | [✔] LeaveMyBarsAlone-v8.0.0-1.20.1-Forge 227 | [✔] lootbeams-1.20.1-1.2.3 228 | [✔] MaxHealthFix-Forge-1.20.1-12.0.2 229 | [✔] MEED-1.20.1-3.7 230 | [✔] memoryleakfix-forge-1.17 -1.1.5 231 | [✔] modernfix-forge-5.13.0 mc1.20.1 232 | [✔] moremcmeta-1.20.1-4.4.7-forge 233 | [✔] mythicmounts-20.1-7.4.2-forge 234 | [✔] Necronomicon-Forge-1.4.2 235 | [✔] oculus-mc1.20.1-1.6.15a 236 | [✔] oldmclogo-1.1.0 237 | [✔] OverflowingBars-v8.0.0-1.20.1-Forge 238 | [✔] paperdoll-forge-1.2.0-mc1.20.1 239 | [✔] PassiveSkillTree-1.20.1-BETA-0.6.10a-all 240 | [✔] Patchouli-1.20.1-84-FORGE 241 | [✔] PickUpNotifier-v8.0.0-1.20.1-Forge 242 | [✔] Placebo-1.20.1-8.6.1 243 | [✔] potacore-0.2.8-universal 244 | [✔] practical_plushies_animals-1.0.2 245 | [✔] puzzle-1.5.2 1.20 246 | [✔] PuzzlesLib-v8.1.17-1.20.1-Forge 247 | [✔] realmrpg_fallen_adventurers_1.0.3_forge_1.20.1 248 | [✔] Reblured-1.20.1-1.3.0 249 | [✔] ResourcePackOverrides-v8.0.3-1.20.1-Forge 250 | [✔] RingsOfAscension-1.20.1-2.0.1 251 | [✔] rubidium-extra-0.5.4 mc1.20.1-build.116 252 | [✔] screenshot_viewer-1.2.1-forge-mc1.20.1 253 | [✔] ServerBrowser-1.20-FORGE-1.1.1 254 | [✔] shulkerboxtooltip-forge-4.0.4 1.20.1 255 | [✔] skinlayers3d-forge-1.6.2-mc1.20.1 256 | [✔] slime-1.5 257 | [✔] sophisticatedbackpacks-1.20.1-3.20.1.1012 258 | [✔] sophisticatedcore-1.20.1-0.6.3.553 259 | [✔] sound-physics-remastered-forge-1.20.1-1.3.1 260 | [✔] spu-1.6 261 | [✔] supermartijn642configlib-1.1.8-forge-mc1.20 262 | [✔] supermartijn642corelib-1.1.17-forge-mc1.20.1 263 | [✔] temporalapi-1.4.2 264 | [✔] textrues_embeddium_options-0.1.5 mc1.20.1 265 | [✔] The_Graveyard_3.1_(FORGE)_for_1.20.1 266 | [✔] tinkerers-smithing-2.6.7 1.20 267 | [✔] Tips-Forge-1.20.1-12.0.4 268 | [✔] treeharvester-1.20.1-8.6 269 | [✔] trimeffects-1.1.1-forge 270 | [✔] uilib-0.3.1-forge 271 | [✔] VisualWorkbench-v8.0.0-1.20.1-Forge 272 | [✔] WI-Zoom-1.5-MC1.20.1-Forge 273 | [✔] worldedit-mod-7.2.15 274 | [✔] XaeroPlus-Forge-1.20.1-68-WM1.37.8-MM23.9.7 275 | [✔] Xaeros_Minimap_23.9.7_Forge_1.20 276 | [✔] XaerosWorldMap_1.37.8_Forge_1.20 277 | [✔] yet-another-config-lib-forge-3.2.2 1.20 278 | [✔] YungsApi-1.20-Forge-4.0.3 279 | [✔] YungsBetterDungeons-1.20-Forge-4.0.3 280 | [✘] YungsBetterEndIsland-1.20-Forge-2.0.5.jar (disabled) 281 | [✔] YungsExtras-1.20-Forge-4.0.3 [✔] AdvancementPlaques-1.20.1-forge-1.5.1 [✔] AnimaticaReforged-1.20.1-0.1.3 [✔] Apotheosis-1.20.1-7.3.0 [✔] apotheotic_additions1.4.5 [✔] ApothicAttributes-1.20.1-1.2.1 [✔] ApothicCurios-1.20.1-1.0.3b [✔] arc-1.4.3-forge [✔] architectury-9.1.13-forge [✔] artifacts-forge-9.2.2 [✔] AttributeFix-Forge-1.20.1-21.0.4 [✔] AutoLeveling-1.20-1.19b [✔] balm-forge-1.20.1-7.2.1 [✔] BarteringStation-v8.0.0-1.20.1-Forge [✔] BetterAnimationsCollection-v8.0.0-1.20.1-Forge [✔] betterdays-1.20.1-3.1.0.3-FORGE [✔] BOMD-Forge-1.20.1-1.1.2 [✔] Bookshelf-Forge-1.20.1-20.1.9 [✔] Bountiful-6.0.3 1.20.1-forge [✔] caelus-forge-3.1.0 1.20 [✔] catalogue-forge-1.20.1-1.8.0 [✔] CerbonsAPI-Forge-1.20.1-1.1.0 [✔] chat_heads-0.10.31-forge-1.20 [✔] cheaper-netherite-smithing-templates-1.0 [✔] chunkloaders-1.2.8a-forge-mc1.20.1 [✔] citadel-2.5.3-1.20.1 [✔] citresewn-1.20.1-5 [✔] cloth-config-11.1.118-forge [✔] Clumps-forge-1.20.1-12.0.0.3 [✔] collective-1.20.1-7.31 [✔] collective-1.20.1-7.32 [✔] comforts-forge-6.3.5 1.20.1 [✔] command-config-0.1.0-beta.4 1.20 [✔] Connector-1.0.0-beta.36 1.20.1 [✔] ConnectorExtras-1.9.3 1.20.1 [✔] continuebutton-1.2.2 1.20 [✔] cupboard-1.20.1-2.3 [✔] curios-forge-5.7.0 1.20.1 [✔] Dave's Potioneering-forge-1.20.1-11 [✔] deeperdarker-forge-1.20.1-1.2.1 [✔] DisenchantmentEditTable-1.20-1.1.2 [✔] elytra_physics-forge-2.0 [✔] elytraslot-forge-6.3.0 1.20.1 [✔] elytratrims-forge-2.0.1 1.20.1 [✔] embeddium-0.3.6 mc1.20.1 [✔] embeddiumplus-1.20.1-v1.2.4 [✔] emi-1.1.2 1.20.1 forge [✔] emiffect-forge-1.1.2 mc1.20.1 [✔] emissive-plugin-1.20.1-2.0.4-forge [✔] emitrades-forge-1.2.1 mc1.20.1 [✔] EnchantingInfuser-v8.0.2-1.20.1-Forge [✔] EnchantmentDescriptions-Forge-1.20.1-17.0.13 [✔] entity_model_features_forge_1.20.1-1.2.3 [✔] entity_texture_features_forge_1.20.1-5.2.3 [✔] entityculling-forge-1.6.2-mc1.20.1 [✔] EquipmentCompare-1.20.1-forge-1.3.7 [✔] essential_1-3-0-6_forge_1-20-1 [✔] extra_compat-1.4.3 [✔] fabric-api-0.92.0 1.11.3 1.20.1 [✘] farsight-1.20.1-3.6.jar (disabled) [✔] Female-Gender-Mod-forge-1.20.1-3.0.1 [✔] ferritecore-6.0.1-forge [✔] followersteleporttoo-1.20.1-2.4 [✔] forgeautofish-6.0.0-1.20.1 [✔] ftb-library-forge-[200](https://mclo.gs/e8RLK1n#L200)1.1.5 [✔] furnitura-1.11-1.20.1 [✔] fusion-1.1.1-forge-mc1.20.1 [✔] geckolib-forge-1.20.1-4.4.2 [✔] gravestone-forge-1.20.1-1.0.14 [✔] guardvillagers-1.20.1-1.6.4 [✔] HeldItemTooltips-v8.0.0-1.20.1-Forge [✔] Iceberg-1.20.1-forge-1.1.18 [✔] immersive_armors-1.6.1 1.20.1-forge [✔] InventorySorter-1.9.0-1.20 [✔] inventorytotem-1.20.1-3.2 [✔] ItemProductionLib-1.20.1-1.0.2a-all [✔] itemrestrictions-1.1.2 [✔] Jade-1.20.1-forge-11.8.0 [✔] jeed-1.20-2.1.7 [✔] jei-1.20.1-forge-15.3.0.4 [✔] jobsplus-1.3-forge [✔] Kambrik-6.1.1 1.20.1-forge [✔] keepcuriosinventory-1.20.1-0.0.1 [✔] kotlinforforge-4.10.0-all [✔] L_Enders_Cataclysm-1.90 -1.20.1 [✔] LeaveMyBarsAlone-v8.0.0-1.20.1-Forge [✔] lootbeams-1.20.1-1.2.3 [✔] MaxHealthFix-Forge-1.20.1-12.0.2 [✔] MEED-1.20.1-3.7 [✔] memoryleakfix-forge-1.17 -1.1.5 [✔] modernfix-forge-5.13.0 mc1.20.1 [✔] moremcmeta-1.20.1-4.4.7-forge [✔] mythicmounts-20.1-7.4.2-forge [✔] Necronomicon-Forge-1.4.2 [✔] oculus-mc1.20.1-1.6.15a [✔] oldmclogo-1.1.0 [✔] OverflowingBars-v8.0.0-1.20.1-Forge [✔] paperdoll-forge-1.2.0-mc1.20.1 [✔] PassiveSkillTree-1.20.1-BETA-0.6.10a-all [✔] Patchouli-1.20.1-84-FORGE [✔] PickUpNotifier-v8.0.0-1.20.1-Forge [✔] Placebo-1.20.1-8.6.1 [✔] potacore-0.2.8-universal [✔] practical_plushies_animals-1.0.2 [✔] puzzle-1.5.2 1.20 [✔] PuzzlesLib-v8.1.17-1.20.1-Forge [✔] realmrpg_fallen_adventurers_1.0.3_forge_1.20.1 [✔] Reblured-1.20.1-1.3.0 [✔] ResourcePackOverrides-v8.0.3-1.20.1-Forge [✔] RingsOfAscension-1.20.1-2.0.1 [✔] rubidium-extra-0.5.4 mc1.20.1-build.116 [✔] screenshot_viewer-1.2.1-forge-mc1.20.1 [✔] ServerBrowser-1.20-FORGE-1.1.1 [✔] shulkerboxtooltip-forge-4.0.4 1.20.1 [✔] skinlayers3d-forge-1.6.2-mc1.20.1 [✔] slime-1.5 [✔] sophisticatedbackpacks-1.20.1-3.20.1.1012 [✔] sophisticatedcore-1.20.1-0.6.3.553 [✔] sound-physics-remastered-forge-1.20.1-1.3.1 [✔] spu-1.6 [✔] supermartijn642configlib-1.1.8-forge-mc1.20 [✔] supermartijn642corelib-1.1.17-forge-mc1.20.1 [✔] temporalapi-1.4.2 [✔] textrues_embeddium_options-0.1.5 mc1.20.1 [✔] The_Graveyard_3.1_(FORGE)_for_1.20.1 [✔] tinkerers-smithing-2.6.7 1.20 [✔] Tips-Forge-1.20.1-12.0.4 [✔] treeharvester-1.20.1-8.6 [✔] trimeffects-1.1.1-forge [✔] uilib-0.3.1-forge [✔] VisualWorkbench-v8.0.0-1.20.1-Forge [✔] WI-Zoom-1.5-MC1.20.1-Forge [✔] worldedit-mod-7.2.15 [✔] XaeroPlus-Forge-1.20.1-68-WM1.37.8-MM23.9.7 [✔] Xaeros_Minimap_23.9.7_Forge_1.20 [✔] XaerosWorldMap_1.37.8_Forge_1.20 [✔] yet-another-config-lib-forge-3.2.2 1.20 [✔] YungsApi-1.20-Forge-4.0.3 [✔] YungsBetterDungeons-1.20-Forge-4.0.3 [✘] YungsBetterEndIsland-1.20-Forge-2.0.5.jar (disabled) [✔] YungsExtras-1.20-Forge-4.0.3

[glea94]

Ok... I found the guilty guy.🙄It doesn't show your item anymore so your gems would not cause issue at all. https://www.curseforge.com/minecraft/mc-mods/apothic-curios edit : oops i see that it's also your mod😬 So i have curios api and your apothic curios cause to unlock your passive skill tree gems and put them in the Apothetic tab, it also unlock the loot of your gems during mining. Maybe that cause the issue of showing multiple bonus issue, idk why but it does. edit2 : tested with only those mods and the bug doesn't shows up🤔 your gems are in the apotheosis tab but there is no bug with your gem now. So another mod do that.😣

[Daripher]

I can't reproduce this issue, also I noticed that you are upgrading armor that can't be upgraded in vanilla. Could this be related?

[Kiragatu]

@Daripher @glea94 I got the same problem and take the source code to finde it out and yea after 3h i got it :) Its realy simple the problem is that the gems not even get remove and new add like the bonus and while the bonus get new in the counts of the gemBonus get add as normal ItemBonus... its rly deep in the code but i found a way out to fix that in a simple way

in the "SkillBonusHandler.java" you finde the problem in the function "setCraftedItemBonus" line: 258 The old code

@SubscribeEvent public static void setCraftedItemBonus(ItemProducedEvent event) { ItemStack stack = event.getStack(); if (PotionHelper.isMixture(stack)) return; Player player = event.getPlayer(); ItemHelper.removeItemBonuses(stack); getSkillBonuses(player, CraftedItemBonus.class).forEach(bonus -> bonus.itemCrafted(stack)); ItemHelper.getItemBonuses(stack, ItemBonus.class).forEach(bonus -> bonus.itemCrafted(stack)); ItemHelper.refreshDurabilityBonuses(stack); }

Now the Gems get remove befor ItemBonus get Add and Gems + GemBonus get add after the proces.

///////////// @SubscribeEvent public static void setCraftedItemBonus(ItemProducedEvent event) { ItemStack stack = event.getStack(); Tag gemsBonusTemp = null, gemsTemp = null; if(stack.hasTag()){ gemsBonusTemp = stack.getTag().get("gem_bonuses"); gemsTemp = stack.getTag().get("gems"); } if (PotionHelper.isMixture(stack)) return; Player player = event.getPlayer(); ItemHelper.removeItemBonuses(stack); if(gemsBonusTemp!=null && gemsTemp!=null) GemItem.removeGemBonuses(stack); getSkillBonuses(player, CraftedItemBonus.class).forEach(bonus -> bonus.itemCrafted(stack)); ItemHelper.getItemBonuses(stack, ItemBonus.class).forEach(bonus -> bonus.itemCrafted(stack)); ItemHelper.refreshDurabilityBonuses(stack); if(gemsBonusTemp!=null && gemsTemp!=null){ stack.getOrCreateTag().put("gem_bonuses",gemsBonusTemp); stack.getOrCreateTag().put("gems",gemsTemp); }}

Also Fix broken items on upgrade for example the mod SimplySwords also works with the Runic Bonus

@Daripher , that should work for every addition of Bonus, so i hope you can add that for all other too :) and enjoin and the file is the last version of CurseForge inc the Fix so if you want just uploud. Would be create if i see there in the in the update info 'thanks to "Kiragatu"' ^.^ just to say yeaii i did it haha. Btw great mod !!!

BTW i forgotten: the mods arnt Incompatibil it was just a misstake by our own you forgotten to remove Gem bonus like ItemBonus on the point :) happens ^.^ hope i help you a lot with that and every one else too! I edit the file and put it back into the PassiveSkillTree-1.20.1-BETA-0.6.13a-all.jar because the PassiveSkillTree-1.20.1-BETA-0.6.13c-all.jar got problems with mousetweaks and something happens with the workbench ^.^ i can also give you my finish jar file for version a and take it to b haha ENJOIN :)