search

DarkArius / aforge

Automatically exported from code.google.com/p/aforge
Other
0 stars 0 forks source link

ignoring 12bit Videoformat fails ... obviously a typo <= instead of >= #397

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

please have a look at VideoCapabilities.cs around line 153 / internal 
VideoCapabilities( IAMStreamConfig videoStreamConfig, int index )

The comment says it will ignore Videoformats >= 12 bit, but the code ignores 
videoformats <= 12 bit

// ignore 12 bpp formats for now, since it was noticed they cause issues on 
Windows 8
// TODO: proper fix needs to be done so ICaptureGraphBuilder2::RenderStream() 
does not fail
// on such formats
if ( BitCount <= 12 )
{
throw new ApplicationException( "Unsupported format found." );
}

above code does the opposite the comment says, please change <= 12 to >=12

What version of the product are you using?

 file date 9.1.2015

Original issue reported on code.google.com by vdMeh...@gmail.com on 2 Feb 2015 at 6:44

GoogleCodeExporter commented 8 years ago 
The comment says exactly what the code does.

Original comment by andrew.k...@gmail.com on 3 Feb 2015 at 9:31