Select Button Screenshot doesn't work at score evaluation, and error at ScreenEndingOkay (whatever that is)

DarkBahamut162 / itg3encore

An upgraded port/edit of ITG3's Encore Theme using the revived ITG3 Theme as its base which now also includes stuff from the Encore Final Theme.

17 stars 0 forks source link

Select Button Screenshot doesn't work at score evaluation, and error at ScreenEndingOkay (whatever that is) #3

Closed dude98 closed 1 year ago

dude98 commented 1 year ago

Pressing the red (Select) button to save screenshots at score evaluation doesn't work anymore, meaning i have to hit the "machine screenshot" (print screen) button.

ProjectOutfox-itg3encore-master.ThemeLua.2023-04-13--19.24.16.log timestamp: 19:41:38

i don't know what it actually means, but it showed up when i disabled event mode and played the final song. the final score evaluation also had a black box on top of the song cards in the middle. this error was a pop up i had to hit ignore on, so it's a proper error and not a warning like the infinite actor command things that were happening earlier in the log.

Edit: warnings right before error says it's missing a file, and then lua code errors.

DarkBahamut162 commented 1 year ago

Several things:

The black box was me loading in the BannerFrame incorrectly. This has been fixed.
The error mentioned in the log (about ScreenEndingOkay) was me forgetting that I moved the credits frame somewhere else and that I should've redirected it to that now moved file. This has now been fixed as well.

But what I didn't/couldn't fix was the screenshot thing. It turns out that only the print-key makes the screenshots happen. I doublechecked on StepMania 5.1 & ITGMania and the sound doesn't even trigger with the select-key over there. You might need to create an issue on OutFox's github repository about that since they seem to have tried to fix that and either aren't finished or it broke between updates somewhere (I actually never noticed any of this). It's another engine issue that's beyond my control/understanding.

dude98 commented 1 year ago

i was using the select button for screenshots just fine when using GLAD renderer (i have screenshots saved in my usb profile's screenshots folder from it)

Edit: the themes that worked with glad (starlight, default, etc.) could do it just fine, haven't checked them while using opengl though.

DarkBahamut162 commented 1 year ago

If I remember correctly, I mentioned that I was having troubles on loading in USB Profile data correctly. I just checked with both video renderer and it works on soundwaves but not on mine (but I remember it then working on the base itg3 one). I'm not sure what I did wrong but I might need to check stuff out there...

Edit: Oh my god... I am a moron... No wonder why the profiles wouldn't load because I did the screen transitions wrong... It now has been fixed but other things might be incorrect (like first "Loading Profiles..." in red but then switching to "Loading..." in blue). This will be fixed in due time as I need to now check a whole load of stuff (and actually add another something that I was about to add if OutFox hadn't screwed up the usb profiles in 0.4.18).