Absolute magnitude patch

DarkEnergySurvey / ugali

Ultra-faint galaxy likelihood toolkit

MIT License

14 stars 15 forks source link

Absolute magnitude patch #57

Closed kadrlica closed 5 years ago

kadrlica commented 5 years ago

This is a patch to allow the results to be created when the absolute magnitude calculation fails (as described in #56). The true fix (i.e. calculating the absolute magnitude for non-DES g,r isochrones) will be more involved.

sidneymau commented 5 years ago

Trying to create the results with this patch still runs into an error. When the code gets to line 266, Mv has not yet been assigned and so the call fails.

kadrlica commented 5 years ago

See if this patch works.

sidneymau commented 5 years ago

We'll need to implement the full fix in the isochrone model: https://github.com/DarkEnergySurvey/ugali/blob/master/ugali/isochrone/model.py#L338-L353 (this has been patched to throw a ValueError instead of an Exception at this stage)