DarkEnergySurvey / ugali

Ultra-faint galaxy likelihood toolkit
MIT License
14 stars 15 forks source link

Update ugali dwarf catalogs #67

Closed mcnanna closed 2 years ago

mcnanna commented 5 years ago

A few issues with the catalogs: Laevens 1 is listed in the ExtraClusters catalog, but the ra, dec, and reference are all for Laevnes 2/Triangulum II. Triangulum II already exists in the ExtraDwarfs catalog. I think the solution is to change the ra, dec, and reference for Laevens 1 to actually be for Laevens 1.

Aquarius II is not in any catalog. It probably belongs in ExtraDwarfs.

McConnachie15 has an object named "Indus I ?", which is actually Indus II.

kadrlica commented 5 years ago

Making this proposal a bit more concrete...

Changes to extra_clusters.csv:

The following changes would be made to extra_dwarfs.csv:

kadrlica commented 5 years ago

Ok, I've uploaded a new catalog tarball: https://github.com/DarkEnergySurvey/ugali/releases/download/v1.7.0/ugali-catalogs.tar.gz

@mcnanna can you confirm that this works? If so, I'll remove the older tarball from the release files.

The files are also available on the DES machines at: ~kadrlica/.ugali/catalogs/extras/

kadrlica commented 5 years ago

@apace7 can you see if we are missing anything else that you know of?

mcnanna commented 5 years ago

Thanks Alex, I'm working on re-running everything through the new mask, but this all looks good to me.


From: Alex Drlica-Wagner notifications@github.com Sent: Friday, April 19, 2019 8:43 AM To: DarkEnergySurvey/ugali Cc: MITCH A MCNANNA; Mention Subject: Re: [DarkEnergySurvey/ugali] Update ugali dwarf catalogs (#67)

Ok, I've uploaded a new catalog tarball: https://github.com/DarkEnergySurvey/ugali/releases/download/v1.7.0/ugali-catalogs.tar.gz

@mcnannahttps://github.com/mcnanna can you confirm that this works? If so, I'll remove the older tarball from the release files.

The files are also available on the DES machines at: ~kadrlica/.ugali/catalogs/extras/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/DarkEnergySurvey/ugali/issues/67#issuecomment-484900154, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKRBXW233IBHHIOT7EQV6WTPRHEAHANCNFSM4HHAVTKA.

mcnanna commented 5 years ago

Two problems I found:

kadrlica commented 5 years ago

Thanks, updates made on DES machines. I'll cut a new version for github once everything has settled down.

apace7 commented 5 years ago

I've added a handful of extra star clusters to the extra_clusters.csv file (I think the tarball should be here). ugali-catalogs.tar.gz

Most of the objects came from http://arxiv.org/abs/1805.06473 (9 mostly with Gaia DR2). The others added are Bliss 1, Munoz 1, and Price-Whelan 1.

kadrlica commented 5 years ago

Found a non-ascii character (I think in DES J0111-1341). I've replaced locally and will propagate into a tarball.

kadrlica commented 2 years ago

To be distributed with v1.8.0. Closed by #94.