search

DarkFlippers / unleashed-firmware

Flipper Zero Unleashed Firmware
https://flipperunleashed.com
GNU General Public License v3.0
17.16k stars 1.43k forks source link

Security Vulnerability - Action Required: Out-of-bounds Write vulnerability may in your project #804

Closed Crispy-fried-chicken closed 3 weeks ago

Crispy-fried-chicken commented 3 weeks ago

Describe the bug.

Hi, we have detected that your project may be vulnerable to Out-of-bounds Write in the function of nfc_device_load_mifare_ul_data in the file of lib/nfc/nfc_device.c . It shares similarities to a recent CVE disclosure https://nvd.nist.gov/vuln/detail/CVE-2022-40363 in the https://github.com/flipperdevices/flipperzero-firmware. The source vulnerability information is as follows:

Vulnerability Detail: CVE Identifier: CVE-2022-40363 Description: A buffer overflow in the component nfc_device_load_mifare_ul_data of Flipper Devices Inc., Flipper Zero before v0.65.2 allows attackers to cause a Denial of Service (DoS) via a crafted NFC file. Reference: https://nvd.nist.gov/vuln/detail/CVE-2022-40363 Patch: https://github.com/flipperdevices/flipperzero-firmware/commit/8d8481b17fdcd0b2f4303b2e88742a94e980c989

Would you help to check if this bug is true? If it's true, I'd like to open a PR for that if necessary. Thank you for your effort and patience!

Reproduction

It is similiar to CVE-2022-40363

Target

No response

Logs

No response

Anything else?

No response

xMasterX commented 3 weeks ago

Hello! nfc_device_load_mifare_ul_data is not present in codebase since NFC refactor, the link you provided points to issue that was fixed 2 years ago in official firmware then merged in our project