search

DarkFlorist / PetalLock

A tool to create immutable ENS sub names
The Unlicense
2 stars 0 forks source link

Contract: Investigate simplifying fuses. #64

Open MicahZoltu opened 2 weeks ago

MicahZoltu commented 2 weeks ago

https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/PetalLock.sol#L72

If we can burn the same set of fuses for the leaf, regardless of whether or not it is the 2LN or NthLN, then we should even if it is unnecessary. Burning fuses is essentially free once you burn one (just an INT update), so burning many/all is fine if it is simpler and achieves the same goal.

MicahZoltu commented 2 weeks ago

Since this is the leaf node, I think we always will receive ownership of it, so we can safely burn fuses without worrying about the correct fuses being set and the name not being transferred to us? Or can a user go through this process when a leaf is correctly configured but a parent isn't?