DarkGhostHunter / Laraconfig

Per-user settings repository system for Laravel
MIT License
173 stars 49 forks source link

Incorrect settable_type value upon migration #29

Open rudolfbruder opened 2 years ago

rudolfbruder commented 2 years ago

Hi,

I am facing issue that when I run the php artisan settings:migrate command my database gets nicely seeded how ever the models do not include backslashes there for $user->settings does not work.

However I found out that if I run $user->settings()->initialize() it will recreate all of the settings with proper settable_type including backslashes. Here is a screenshot:

image

I am able to solve this issue by editing the fillSettings method in Pipes\CreateNewMetadata.php file like this: image However I am not sure if it is the proper approach.

Can someone please help me why is this behavior here?

rudolfbruder commented 2 years ago

Unfortunately the merge request (Issue 21) has not solved my problem. I tried it on windows as well as on mac and still when i run php artisan settings:migrate the settable_type is inserted without backslashes like this: AppModelsUserUser

Any advice please? Am I doing something wrong?

Thanks!

divdax commented 2 years ago

Same issue here.

rudolfbruder commented 2 years ago

@divdax I had to create a fork until this gets fixed :)

DarkGhostHunter commented 2 years ago

Can someone test this works on master?

My old PC went to hell.

rudolfbruder commented 2 years ago

Nah did not work after your last approved pull request. Still using my fork.

rudolfbruder commented 2 years ago

@DarkGhostHunter Hey, can we do something about this? Should raise a PR?

DarkGhostHunter commented 2 years ago

@DarkGhostHunter Hey, can we do something about this? Should raise a PR?

Pleas, hands full.

rudolfbruder commented 2 years ago

Raised #35 for this one @DarkGhostHunter. Can you please take a look?