search

DarkGhostHunter / Laraconfig

Per-user settings repository system for Laravel
MIT License
173 stars 49 forks source link

Add static analysis #4

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

Please start CI :)

szepeviktor commented 3 years ago

@DarkGhostHunter Please consider running static analysis. https://github.com/szepeviktor/Laraconfig/runs/3106068821?check_suite_focus=true 👀

DarkGhostHunter commented 3 years ago

What when why how?

szepeviktor commented 3 years ago

As in this PR: https://github.com/DarkGhostHunter/Laraconfig/pull/4/files

  1. Install Larastan
  2. Run it :)

The above CI output shows some problems/typos/false positives.

DarkGhostHunter commented 3 years ago

Thanks but I'm not interested in static analysis... yet (specially when on many false positives and magic methods).