DarkGhostHunter / Laraguard

"On-premises 2FA Authentication for all your users out-of-the-box
MIT License
266 stars 24 forks source link

Add support for laravel 7 #10

Closed victorlap closed 4 years ago

victorlap commented 4 years ago

Maybe add something like the following? Or do you want to drop support for laravel 6 altogether?

DarkGhostHunter commented 4 years ago

Well, the plan is to have support for the LTS and the latest version. If GitHub actions can help with testing both framework versions, then that's good.

Currently I haven't check further GitHub Actions for that matter.

DarkGhostHunter commented 4 years ago

After trying with multiple ways to have PHP, Laravel, Orchestra Testbench, PHPUnit and Coveralls playing nicely, I came to the conclusion it's just better to drop support for the last version, otherwise I will have to welcome my old friend dependency hell.

victorlap commented 4 years ago

If you are still interested. I got it working just now. See https://github.com/victorlap/Laraguard/actions/runs/49411880/workflow