search

DarkGhostHunter / Laraguard

"On-premises 2FA Authentication for all your users out-of-the-box
MIT License
266 stars 24 forks source link

Added support for Laravel 8 #48

Closed juanparati closed 4 years ago

juanparati commented 4 years ago

I added the required dependencies for Laravel 8 into the composer.json.

I also run all unit tests against Laravel 8 framework and all has been passed (By the way did you notice how fast the test are executed in comparison with PHPUnit 8.x?)

PHPUnit 9.3.8 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.8 with Xdebug 2.9.1
Configuration: /X/Projects/tmp/Laraguard/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

................................................................. 65 / 96 ( 67%)
...............................                                   96 / 96 (100%)

Time: 00:22.984, Memory: 42.00 MB

OK (96 tests, 411 assertions)

I had to add "laravel/legacy-factories" in order to maintain the factories compatible with Laravel 8 and I also upgraded PHPUnit.

juanparati commented 4 years ago

Note: In order to run the test in Laravel 8 is required to install legacy-factories.

The problem is that "legacy-factories" doesn't work in Laravel 6 and 7. I suggest to create a new branch for Laravel 8.

nathan-io commented 4 years ago

Thanks for this commit! Would love to see this merged and a new release. We're currently upgrading to Laravel 8 and this package (while greatly appreciated!) is preventing us from completing the upgrade.

nathan-io commented 4 years ago

If you need to get this working on Laravel 8, here's what did it for me:

In composer.json, change your version of "darkghosthunter/laraguard" to "dev-master" in the require block, and add the following to repositories:

        {
            "type": "vcs",
            "url":  "git@github.com:/juanparati/Laraguard.git"
        }
deligoez commented 4 years ago

Hi, when this pull request will be merged?

denydias commented 4 years ago

I'm getting worried about @DarkGhostHunter!!! His profile shows no activity in the last 70 days which is quite unusual inactivity interval based on the last 12 month data. I truly wish all is well with him!

juanparati commented 4 years ago

I hope that @DarkGhostHunter will back soon. 🙏

padre commented 4 years ago

@DarkGhostHunter we need you, please!

denydias commented 4 years ago

I'm glad to know all is well with you, @DarkGhostHunter!!!

juanparati commented 4 years ago

@DarkGhostHunder: Good to see you merging commits again!

I hope that everything is fine there.

Un saludo y gracias!

rappasoft commented 4 years ago

@DarkGhostHunter can you tag a new release?

denydias commented 3 years ago

Hi, @DarkGhostHunter. I wish all is well with you and your family!

Do you plan to tag a new release with this PR?