Closed juanparati closed 4 years ago
Note: In order to run the test in Laravel 8 is required to install legacy-factories.
The problem is that "legacy-factories" doesn't work in Laravel 6 and 7. I suggest to create a new branch for Laravel 8.
Thanks for this commit! Would love to see this merged and a new release. We're currently upgrading to Laravel 8 and this package (while greatly appreciated!) is preventing us from completing the upgrade.
If you need to get this working on Laravel 8, here's what did it for me:
In composer.json
, change your version of "darkghosthunter/laraguard"
to "dev-master"
in the require
block, and add the following to repositories
:
{
"type": "vcs",
"url": "git@github.com:/juanparati/Laraguard.git"
}
Hi, when this pull request will be merged?
I'm getting worried about @DarkGhostHunter!!! His profile shows no activity in the last 70 days which is quite unusual inactivity interval based on the last 12 month data. I truly wish all is well with him!
I hope that @DarkGhostHunter will back soon. 🙏
@DarkGhostHunter we need you, please!
I'm glad to know all is well with you, @DarkGhostHunter!!!
@DarkGhostHunder: Good to see you merging commits again!
I hope that everything is fine there.
Un saludo y gracias!
@DarkGhostHunter can you tag a new release?
Hi, @DarkGhostHunter. I wish all is well with you and your family!
Do you plan to tag a new release with this PR?
I added the required dependencies for Laravel 8 into the composer.json.
I also run all unit tests against Laravel 8 framework and all has been passed (By the way did you notice how fast the test are executed in comparison with PHPUnit 8.x?)
I had to add "laravel/legacy-factories" in order to maintain the factories compatible with Laravel 8 and I also upgraded PHPUnit.