search

DarkHobbit / doublecontact

Offline DE-independent Qt-based contact manager primarily for phonebooks editing/merging. Beta.
GNU General Public License v3.0
52 stars 11 forks source link

Spelling: Unknown message format #42

Closed comradekingu closed 4 years ago

comradekingu commented 4 years ago

Alternatively, "Unknwon format for messages".

DarkHobbit commented 4 years ago

Thanks for your work. Unfortunately, some of your chages are destructives or questionable. For example, replacement Ok -> OK broke program build, because C++ identifiers are case-sensitive. "File name" or "filename" both are valid variations. In this case (and some other), I won't let excess work to translators in other languages. "Photo", not "image" is standard tag name according vCard specifications. "TODO" comments aren't subject for spelling because it will be removed from source after fixes (but I agree that I need to write more competently in future). "Unknown messages format"... in this case, plural is more correct, because this is format of entire message group, not one message.

SUMMARY: I made separately some of your changes, but PR will be rejected. I hope our cooperation in Norwegian translation will be continued.