DarkKronicle / KronHUD

A mod to add clean and useful HUD widgets.
GNU General Public License v3.0
92 stars 38 forks source link

update to 1.20.1 #145

Closed moehreag closed 1 year ago

moehreag commented 1 year ago

If you want to test this PR before https://github.com/DarkKronicle/DarkKore/pull/6 is merged:

moehreag commented 1 year ago

LGTM (i'm just too fast zap!)

Btw, I think you might simply be able to use your commit hash instead since i think it may be using JitPack. Maybe the repo needs changing too? idk

It probably is using jitpack, but it doesn't seem like it builds artifacts for prs

TheKodeToad commented 1 year ago

image

https://discord.com/channels/817576132726620200/1112802443135303700/1121539905055637524 (via https://discord.quiltmc.org)

moehreag commented 1 year ago

image

https://discord.com/channels/817576132726620200/1112802443135303700/1121539905055637524 (via https://discord.quiltmc.org)

iirc the new maven address wasn't in their readme yet when we did this which is why it isn't changed yet

TheKodeToad commented 1 year ago

I brought it up as I feel it's something which could be done in this pull request!

moehreag commented 1 year ago

KronHUD doesn't actually depend on Satin, DarkKore does: https://github.com/DarkKronicle/DarkKore/pull/6/commits/5b1068998ed9bae63ebb3977768530dab256db65

TheKodeToad commented 1 year ago

Ahh

:thinking: The maven URL is in KronHUD too, though

moehreag commented 1 year ago

Ahh

thinking The maven URL is in KronHUD too, though

probably because of the transitive dependencies