DarkKronicle / KronHUD

A mod to add clean and useful HUD widgets.
GNU General Public License v3.0
93 stars 39 forks source link

Add more customisation and fix some bugs. #25

Closed TheKodeToad closed 3 years ago

TheKodeToad commented 3 years ago

Adds more customisation:

Also changes some of the text to be more user friendly (e.g. "PotionEffectsHUD" -> "Potion Effects"), fixes #23 and makes some HUDs wider to be the same width as the keystrokes HUD (screenshot in issue #5 shows why this would be useful). I also stole a bit of Minecraft's code to make it possible to draw a rectangle using floats, because I couldn't think of a better way.

Also, shall I open another pull request to use ClothConfig instead of Polish (like with AdvancedChat)? Polish looks nicer than ClothConfig in some ways, but it has some issues:

Some of these issues could be fixed, but in my opinion ClothConfig works fine and feels more consistent.

DarkKronicle commented 3 years ago

All the changes are looking nice! I do think that Polish isn't as 'polished' as it needs to be to stand in for a configuration (configs can be hard). I've now written 4 different types of configurations using/combining different API's. All of them have their different strengths, but the one that I think would be the best is using MaLiLib built in configuration. Unlike cloth, it allows you to customize anything easily and gives you a lot of control. It is more complex to implement, but it would probably be best for the long run.

Do you have any thoughts on it?

TheKodeToad commented 3 years ago

I haven't really used Cloth that much, because I usually just use the built-in classes, but I think it would be possible to create the existing config screen using Cloth, but the layout would have to be completely changed, but I don't think that would ruin the configuration - CollapsibleObjects could be used to separate each HUD.

If you want more control though, I think the built-in classes (Screen, ButtonWidget, etc.) would work pretty well.

TheKodeToad commented 3 years ago

@DarkKronicle Is there anything else to change, or have you just not got round to merging?

DarkKronicle commented 3 years ago

Sorry, I've been pretty busy. I'll try to test this and merge it tomorrow.

Hi30MC commented 3 years ago

@DarkKronicle will you update the curse forge page with a new .jar? I can't compile it on this pc.

TheKodeToad commented 3 years ago

@HiHi3690 KronHUD-1.1.1.jar.zip. Make sure to delete the .zip at the end after downloading. The version number should be updated first before uploading to CurseForge.

jeffrgh commented 3 years ago

Guys this latest version is not on CurseForge

TheKodeToad commented 3 years ago

Yep. I know.