search

DarkKronicle / KronHUD

A mod to add clean and useful HUD widgets.
GNU General Public License v3.0
93 stars 39 forks source link

1.19 Support #63

Closed Paradox-77 closed 2 years ago

Paradox-77 commented 2 years ago

This mod is absolutely amazing, and have made this my main hud mod ever since its infancy days. I would love to continue using it in the newer versions of the game. Please do update the mod when you are able to. Thank you so much!

moehreag commented 2 years ago

This is currently not possible due to malilib not being available for 1.19.

Paradox-77 commented 2 years ago

Oh yeah right, masa wants to rewrite all his mods. Forgot KronHUD needed malilib.

TheKodeToad commented 2 years ago

Oh yeah right, masa wants to rewrite all his mods. Forgot KronHUD needed malilib.

sounds of pain

I hope I'm not expected to port it too DarkKore too.

RoonMoonlight commented 2 years ago

According to MaLiLib CurseForge page, MaLiLib code rewrite is ongoing

I guess this mod won't be updated unless they complete code rewrite process for MaLiLib

Paradox-77 commented 2 years ago

There are already community ports of malilib for 1.19. They can be found here

Any chance KronHUD might get a small patch for 1.19 with the community port of malilib?

RoonMoonlight commented 2 years ago

There are already community ports of malilib for 1.19. They can be found here

Any chance KronHUD might get a small patch for 1.19 with the community port of malilib?

I don't think this is going to be updated unless MaLiLib officially gets 1.19 port

Community ports are unofficial and it should be considered risky

Paradox-77 commented 2 years ago

There are already community ports of malilib for 1.19. They can be found here Any chance KronHUD might get a small patch for 1.19 with the community port of malilib?

I don't think this is going to be updated unless MaLiLib officially gets 1.19 port

Community ports are unofficial and it should be considered risky

Yes, I know the risk of using a community port, the ports are from a trusted and long-time member of the technical community. But as you said its not always a good idea trusting random strangers on the internet

realbymaxgames commented 2 years ago

yeah but please give us kronhud 1.19 with the community ported mailib.i don ´t wanna use a client for keystrokes

ghost commented 2 years ago

There are already community ports of malilib for 1.19. They can be found here Any chance KronHUD might get a small patch for 1.19 with the community port of malilib?

I don't think this is going to be updated unless MaLiLib officially gets 1.19 port Community ports are unofficial and it should be considered risky

Yes, I know the risk of using a community port, the ports are from a trusted and long-time member of the technical community. But as you said its not always a good idea trusting random strangers on the internet

I think the issue is more that the community port is unofficial, won't be updated/receive as much support as an in-house port by the developers.

Thus, I think we should just wait until it gets officially ported to 1.19 :grin:

You can fork this mod, port everything non-MaLiLib to 1.19 since lots of mostly text-related stuff changed drastically and replace the MaLiLib version with the community port to 1.19 while we wait for it to be officially ported.

TheKodeToad commented 2 years ago

The mod was never actually "officially" updated to 1.17. I just opened a pull request and it was merged.

So if anyone does make a fork, I'm sure there's a possibility that it will be merged if a pull request is opened.

There's nothing wrong with using a community port of MaLiLib, as the fork is open source like the original.

C0reyKalier commented 2 years ago

masa said that he's abandoning the plan to have the "official" 1.19 mod versions that's based on the new code from 1.12.2, so the 1.19 malilib is still based on the old code. Although he'll publish testing versions of 1.19 based on the new code in his Discord server, it won't be uploaded to CurseForge.

RoonMoonlight commented 2 years ago

masa said that he's abandoning the plan to have the "official" 1.19 mod versions that's based on the new code from 1.12.2, so the 1.19 malilib is still based on the old code. Although he'll publish testing versions of 1.19 based on the new code in his Discord server, it won't be uploaded to CurseForge.

That's great news! I thought it is better to seperate the development codebase (With new one and old one) while having compatibility with current MC version... Maybe he made the right choice

Now we can get update to support 1.19 in no time!

TheKodeToad commented 2 years ago

I think I will work on this unless moehreag wants to or DarkKronicle wants it to use DarkKore now.

moehreag commented 2 years ago

I think I will work on this unless moehreag wants too.

Unless DarkKronicle wants it to use DarkKore now.

Please do if you want, I'm not at home this week. (Unless the DarkKore case comes true)

TheKodeToad commented 2 years ago

I've done it. Just need to wait for the pull request to be merged.

Paradox-77 commented 2 years ago

Thank you so much @TheKodeToad, I had to use sodium extra's coord HUD until now. It's hideous compared to KronHUD. I'll leave the issue open for now.

DarkKronicle commented 2 years ago

I think I will work on this unless moehreag wants too. Unless DarkKronicle wants it to use DarkKore now.

Please do if you want, I'm not at home this week. (Unless the DarkKore case comes true)

DarkKore will probably be in the future if I get enough motivation