On first install / when there are no transactions in the transaction table, the ProgressBar in the MainActivity never dismisses - this is caused by an early return in the Repository / LocalDataSource. The callback with the list of dummy transactions is never called, so we're left in limbo.
An addition to the callback to let the repository / presenter know that there is none to display would fix this, or we could just return an empty List.
On first install / when there are no transactions in the transaction table, the ProgressBar in the MainActivity never dismisses - this is caused by an early return in the Repository / LocalDataSource. The callback with the list of dummy transactions is never called, so we're left in limbo.
An addition to the callback to let the repository / presenter know that there is none to display would fix this, or we could just return an empty List.