DarkNormal / Airgead

0 stars 0 forks source link

ProgressBar never dismisses when there are no transactions in the DB #14

Closed DarkNormal closed 7 years ago

DarkNormal commented 7 years ago

On first install / when there are no transactions in the transaction table, the ProgressBar in the MainActivity never dismisses - this is caused by an early return in the Repository / LocalDataSource. The callback with the list of dummy transactions is never called, so we're left in limbo.

An addition to the callback to let the repository / presenter know that there is none to display would fix this, or we could just return an empty List.

DarkNormal commented 7 years ago

Commit 42805f0 resolves - but a "no transactions yet!" should replace the RecyclerView instead if it's empty