DarkPacks / SevTech-Ages

SevTech: Ages is a massive Minecraft modpack packed with content and progression.
https://minecraft.curseforge.com/projects/sevtech-ages
GNU General Public License v3.0
228 stars 78 forks source link

[3.1.1] Rock Crystal Ore blocks can be moved using Chisel and Bits #3761

Open tommysundling opened 5 years ago

tommysundling commented 5 years ago

Issue / Bug

Rock Crystal Ore drops normal Rock Crystals instead of the ore block when mined with a tool from Tinkers with the Silk Touch modifier. The silk touch works as expected on regular Stone blocks.

Expected Behavior

Blocks mined with silk touch normally drop themselves instead of their standard drop.

Possible Solution

Make it so Rock Crystal Ore drops the Rock Crystal Ore block when mined with Silk Touch, rather than Rock Crystals.

Steps to Reproduce (for bugs)

Find Rock Crystal Ore in the Overworld dimension Mine it with a Silk Touch pickaxe from Tinkers' Contruct

Context

My intention was to use the Rock Crystal Ore blocks to grow Celestial Crystals on.

I'm running a server and recently upgraded server and client from v3.0.8 to v3.1.1. The Rock Crystal blocks were close to base so they were generated before the upgrade.

sam-kirby commented 5 years ago

I'm afraid that's working as intended, Crystal Ore can not be silk touched by any means.

It also doesn't provide any advantage for growing your rock crystal on, for that you want Star Metal ore, which you can transform in place or produce through crafting and place where you need it.

tommysundling commented 5 years ago

Thank you for the clarification and tip @sk2048. I watched this video which indicated that there was some inherent fortune effect to stardust when growing Celestial Crystals on Rock Crystal Ore. Do you happen to know if that is no longer the case?

When rewatching the video I noticed that he earlier in the video mentioned that he used Chisel and Bits to move the Rock Crystal Ores ;-)

I just tested with Chisel & Bits and can confirm that I can use that to move the Rock Crystal Ore to wherever I want. Is that not intended?

sam-kirby commented 5 years ago

I've looked through Astral's code, since the bonus was introduced it has only ever checked whether the block it is on top of is Starmetal ore. I believe the author of the video must have made a mistake.

They grow faster, have a chance to gain extra purity and also have a chance to drop a second crystal if you grow them on starmetal ore.

It's not intended that you can move it using chisel and bits.

tommysundling commented 5 years ago

Someone on the Internet was mistaken about something? Say it cannot be so! :-P

Appreciate the help with this question, now I know I'll need to work with Starmetal Ore to get the bonus, and that's easy enough. Thanks!