DarkPacks / SevTech-Ages

SevTech: Ages is a massive Minecraft modpack packed with content and progression.
https://minecraft.curseforge.com/projects/sevtech-ages
GNU General Public License v3.0
229 stars 79 forks source link

Rock Crystal Texture #643

Closed MongoTheElder closed 6 years ago

MongoTheElder commented 6 years ago

Like the Aquamarine block, the Rock Crystal block is invisible

2018-03-11_21 17 29

justinrusso commented 6 years ago

Seems to be the same issue as #624.

I've found a workaround for this. Ideally though we can pass this along to get fixed. I'm not sure who is at fault here.

Darkosto commented 6 years ago

What the heck is going on with these blocks?! Is it only Content Tweaker? Does it have to do with a resource folder issue?

justinrusso commented 6 years ago

No one knows.

Darkosto commented 6 years ago

https://www.youtube.com/watch?v=s88r_q7oufE

justinrusso commented 6 years ago

Youre full of youtube links today.

artdude543 commented 6 years ago

I've found the issue; looking into a better fix than copying over Vanilla assets. Then I'll speak about the mod to blame :P

artdude543 commented 6 years ago

Okay, so the mod which was causing the issue is Better with Mods not completely the mods fault, however. As it's creating a custom CTM for his own things (from what I can see in the code) and the change does not specify the default minecraft:blocks/stone texture in the textures array only his own textures.

From then what I can gather when the models/textures are being baked; the CTM is changing the model which in turn when CT is trying to use the stone model references it's loading the model fine but the variant is broken as it's not set to the one BWM had set up. This could be a bug on CTM's side but I don't think so but technically this should be breaking the stone texture itself also but it's not 🤔

But regardless the fix for now (which is better than copying Vanilla assets) is to overwrite the mcmeta file BWM is creating and putting it in the resources folder which will remove the CTM variant BWM is trying to make. It's a break in his texture but it's a small cost to fix the issue.

Fix/File Details

Location

resources\minecraft\textures\blocks\stone.png.mcmeta

Contents

{}

This will fix the issue and the stone texture appears again for CT custom stone variants.

Alternative Contents

This adds the default stone into the array of supported textures for BMW CTM type which fixes the issue and I guess still allow the mods thing to work but I never saw it in the game tbh so no idea how it's supposed to show.

{
   "ctm": {
     "ctm_version": 1,
     "type": "bwm_strata",
     "layer": "SOLID",
     "textures": [
    "minecraft:blocks/stone", // Add the default stone as the first texture.
        "minecraft:blocks/stone_1",
        "minecraft:blocks/stone_2"
     ]
   }
}

Working Example

So yeah this was a fun issue to track down and look into fixing. But we have two fixes or we could talk to the developers of CTM or BWM to find out what is truly breaking the base stone model; for references usage. As this only seems to affect anything, not Minecraft trying to use the model/texture for their own needs. It even could be CT doing something odd but I doubt that.

primetoxinz commented 6 years ago

I have made a commit to BWM that will make sure that our HCStrata CTM support is no longer available when the feature is disabled. That should at least fix this issue for SevTech and other packs that do not have HCStrata.

artdude543 commented 6 years ago

That won't fix the issue completely cos of the stone.mcmeta file in the mod itself which needs to be removed/changed.

primetoxinz commented 6 years ago

the mcmeta file should not load as the "type": "bwm_strata" is not registered to the CTM TextureTypeRegistry

artdude543 commented 6 years ago

Have you got a build for me to test in my debug pack?

primetoxinz commented 6 years ago

http://ci.blamejared.com/job/BetterWithMods/363/

artdude543 commented 6 years ago

Thanks; I still think there is more to this. As the CTM should not break the baked model at all. As other mods which re-use the stone don't seem to be affected to the extent of CT. When I get more time I'll try to debug it further.

primetoxinz commented 6 years ago

Yeah, just thought it would be best to at least have a bandaid so people aren't seeing through the world

artdude543 commented 6 years ago

Okay so yeah @Darkosto the latest build also fixes the issue, so either or works from the stuff above or the new patch.

I'll re-look at the issue when I get time unless someone else tracks it down.

Darkosto commented 6 years ago

Hey @MongoTheElder when you're able, can you check this on Beta 3 to make sure it's good in the modpack? :D