search

DarkPacks / SkyFactory-4

SkyFactory 4 offers a brand-new experience never before seen in the series. Full automation, tech, magic, and bacon resources! This iteration offers over 30+ world types so you can play the pack like never before!
https://minecraft.curseforge.com/projects/skyfactory-4/
134 stars 46 forks source link

Game lag spiking every block break/block place (heavy spikes, full freeze) #1837

Open surgerysteve opened 3 years ago

surgerysteve commented 3 years ago

Bug Description

Noticeable large freezing lag spikes upon block breaking and placing, only have a starter world going, expanding my platform pretty far and now lag upon every block place. Have added optifine to no avail, have lowered all settings to no avail. running on 2080 super and amd ryzen 5 3600x and 32gbs of ram, with 16 allocated. task manager and game frames are not spiking but latency goes through the roof of the screen upon any block place, immediately. ### Did this behavior use to work in the previous version? hasnt happened for awhile, occasionally but mainly after i expanding my platform wider did it begin occuring ## Steps to Reproduce (for bugs)

1. 2. 3.

Logs

World Information

Client Information

wally314garcia commented 3 years ago

This isn't an issue with Skyfactory or any other modpack, this is an issue with Minecraft itself and how it handles lighting updates.

Let's say your at world height (255) and break a block that is dark below it all the way to the ground (64) you are updating a 15x15 area (since light spreads 15 blocks in all 4 directions from the block you broke) that is ~191 blocks tall (255-64). So then we have 15x15x191= 42,975

So from breaking that 1 block the light values of over 40,000 blocks are being updated. That's what causes the lag spike.

surgerysteve commented 3 years ago

the old instances of skyfactory ran this just fine however. I was able to make a much much larger base with machines well before lag whereas i was lagging behind in this pack before i even got out of acorn farming trees. Definitely get what you're saying but something is off with this compared to old versions of sky factory as ive never experienced that kind of update lag each block in any other version or previous pack, with far more building having been done. it didnt start initially, it only started happening when i got to building my platform out more.

On Thu, Apr 8, 2021 at 4:46 PM wally314garcia @.***> wrote:

This isn't an issue with Skyfactory or any other modpack, this is an issue with Minecraft itself and how it handles lighting updates.

Let's say your at world height (255) and break a block that is dark below it all the way to the ground (64) you are updating a 15x15 area (since light spreads 15 blocks in all 4 directions from the block you broke) that is ~191 blocks tall (255-64). So then we have 15x15x191= 42,975

So from breaking that 1 block the light values of over 40,000 blocks are being updated. That's what causes the lag spike.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DarkPacks/SkyFactory-4/issues/1837#issuecomment-816178698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2FSHPFF6WEAL5AU2HNJX3THYI2NANCNFSM4XPKOA6A .

wally314garcia commented 3 years ago

The older versions of Skyfactory were also running older versions of Minecraft that used a different lighting engine. The engine was upgraded in 1.8 that allowed for better detection and removal of black spots in the game at the cost of increased TPS. To check I loaded up Skyfactory 2.5 (which runs on Minecraft 1.7.10) and Skyfactory 3 (which runs on Minecraft 1.10.2) and that noticeable lag spike exists in Skyfactory 3 but not in Skyfactory 2.5.

https://minecraft.fandom.com/wiki/Light#History 1.8 - 14w30a - The lighting engine was significantly improved, removing most black spots present in world generation.

surgerysteve commented 3 years ago

So theres no avoiding it whatsoever then though?

On Thu, Apr 8, 2021, 5:02 PM wally314garcia @.***> wrote:

The older versions of Skyfactory were also running older versions of Minecraft that used a different lighting engine. The engine was upgraded in 1.8 that allowed for better detection and removal of black spots in the game at the cost of increased TPS. To check I loaded up Skyfactory 2.5 (which runs on Minecraft 1.7.10) and Skyfactory 3 (which runs on Minecraft 1.10.2) and that noticeable lag spike exists in Skyfactory 3 but not in Skyfactory 2.5.

https://minecraft.fandom.com/wiki/Light#History 1.8 - 14w30a - The lighting engine was significantly improved, removing most black spots present in world generation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DarkPacks/SkyFactory-4/issues/1837#issuecomment-816195756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2FSHNBN2M65AQT2N5BAJTTHYKWJANCNFSM4XPKOA6A .

surgerysteve commented 3 years ago

Thank you for looking into it nonetheless

On Thu, Apr 8, 2021, 5:16 PM Surgerysteve @.***> wrote:

So theres no avoiding it whatsoever then though?

On Thu, Apr 8, 2021, 5:02 PM wally314garcia @.***> wrote:

The older versions of Skyfactory were also running older versions of Minecraft that used a different lighting engine. The engine was upgraded in 1.8 that allowed for better detection and removal of black spots in the game at the cost of increased TPS. To check I loaded up Skyfactory 2.5 (which runs on Minecraft 1.7.10) and Skyfactory 3 (which runs on Minecraft 1.10.2) and that noticeable lag spike exists in Skyfactory 3 but not in Skyfactory 2.5.

https://minecraft.fandom.com/wiki/Light#History 1.8 - 14w30a - The lighting engine was significantly improved, removing most black spots present in world generation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DarkPacks/SkyFactory-4/issues/1837#issuecomment-816195756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2FSHNBN2M65AQT2N5BAJTTHYKWJANCNFSM4XPKOA6A .

wally314garcia commented 3 years ago

So theres no avoiding it whatsoever then though?

Unfortunately not, as this issue is with Minecraft itself.

Out of curiosity I searched online and found many other people having this exact same issue under the same circumstances with pretty much every skyblock style modpack out there running Minecraft 1.8 or newer with one exception, Botania Skies.

Botania Skies has over 1,600 downloads and zero issues reported. It was also made for Minecraft 1.14 and newer.

Minecraft 1.14.2 and newer packs do not suffer as much of a lag spike due to how Minecraft calculates light at world load. This changed can be explained by the update to the lighting engine in Minecraft 1.14.2 pre4.

What this means going forward is that any new skyblock style modpacks made for Minecraft 1.16 will not suffer near as bad a lag spike when updating light levels of massive amounts of blocks. This includes Skyblock as Darkosto is working on a remake of Skyfactory 1.

surgerysteve commented 3 years ago

That's awesome, a remake of sky factory 1 is what I've always wanted really anyways. Is there a planned release date for that remake and what launcher will it be on?

On Thu, Apr 8, 2021, 5:36 PM wally314garcia @.***> wrote:

So theres no avoiding it whatsoever then though? … <#m_2816053996345054967m-4872688544526835029_> On Thu, Apr 8, 2021, 5:02 PM wally314garcia @.***> wrote: The older versions of Skyfactory were also running older versions of Minecraft that used a different lighting engine. The engine was upgraded in 1.8 that allowed for better detection and removal of black spots in the game at the cost of increased TPS. To check I loaded up Skyfactory 2.5 (which runs on Minecraft 1.7.10) and Skyfactory 3 (which runs on Minecraft 1.10.2) and that noticeable lag spike exists in Skyfactory 3 but not in Skyfactory 2.5. https://minecraft.fandom.com/wiki/Light#History 1.8 - 14w30a - The lighting engine was significantly improved, removing most black spots present in world generation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1837 (comment) https://github.com/DarkPacks/SkyFactory-4/issues/1837#issuecomment-816195756>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2FSHNBN2M65AQT2N5BAJTTHYKWJANCNFSM4XPKOA6A .

Unfortunately not, as this issue is with Minecraft itself.

Out of curiosity I searched online and found many other people having this exact same issue under the same circumstances with pretty much every skyblock style modpack out there running Minecraft 1.8 or newer with one exception, Botania Skies.

Botania Skies has over 1,600 downloads and zero issues reported. It was also made for Minecraft 1.14 and newer.

Minecraft 1.14.2 and newer packs do not suffer as much of a lag spike due to how Minecraft calculates light at world load. This changed can be explained by the update to the lighting engine in Minecraft 1.14.2 pre4.

What this means going forward is that any new skyblock style modpacks made for Minecraft 1.16 will not suffer near as bad a lag spike when updating light levels of massive amounts of blocks. This includes Skyblock as Darkosto is working on a remake of Skyfactory 1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DarkPacks/SkyFactory-4/issues/1837#issuecomment-816229054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2FSHJAAABEAWTE6FEEDKLTHYOUJANCNFSM4XPKOA6A .

wally314garcia commented 3 years ago

No release date as far as I am aware of. It will most likely be posted on Curse Forge so you will be able to download the zip and use whatever launcher you prefer.

https://www.twitch.tv/darkosto