DarkPlacesEngine / DarkPlaces

The DarkPlaces Quake engine, created by LadyHavoc. Official Git repository (replaces SVN).
https://icculus.org/twilight/darkplaces/
GNU General Public License v2.0
273 stars 39 forks source link

[ft2] should we remove the `r_font_use_alphatexture`? It’s broken for a long time #69

Closed NaitLee closed 8 months ago

NaitLee commented 1 year ago

As the developer of #67 I had to deal with the r_font_use_alphatexture thing appeared in ft2.c. Workarounds like this are considered (before testing and finding out this true issue) but didn’t rescue this fact —

After searching around I’ve found that this commit in master cause the configuration r_font_use_alphatexture 1 to segfault the game, and probably also caused #66.

That commit is from 2018 and so far no relative hassles have been reported, that further explains that this “feature” isn’t used.

For the ease of code maintenance (and #67) it’s suggested to remove it just like #66.

Other notes:

bones-was-here commented 1 year ago

Probably it worked when implemented, but I expect the newer font features and more generic rendering paths aren't compatible. For saving font memory in VRAM there's r_font_compress which still works.

bones-was-here commented 8 months ago

I removed the last bits f0f6982297b24bf60c35503f705a11d83a549cfe