DarkSector / python-particle

Python Wrapper around the Particle (particle.io) API
https://www.pronoy.in/2015/08/21/python-particle/
MIT License
12 stars 4 forks source link

Local wifi setup improvements #8

Closed antoniovazquezblanco closed 4 years ago

antoniovazquezblanco commented 4 years ago

For the time being I have moved the wifi setup parameters only to the relevant function. I also created a call to the wifi setup command with a file as a parameter.

Those are quick changes that I thought you may want but I would like to perform but that I want to consult with you first:

  1. I would like to separate local and api calls into two files if possible. Both classes seem uterly unrelated and smaller files helps readability and maintenance.

  2. I would like to make pexpect optional so that I can use your package in windows based machines.

Please, let me know wether those changes are fine with you. If you prefer those changes in smaller PRs I would be willing to do so.

Thanks