DarkShadow44 / CptsModdingLight

Do What The F*ck You Want To Public License
5 stars 1 forks source link

Torch Particles Not Actually Fixed, Colored Lamp Light Not Loading from Save #11

Closed DarianLStephens closed 3 years ago

DarianLStephens commented 5 years ago

They seem to be taking the color of skylight, since during the day, the flames will be bright and roughly as you'd expect (Though I feel they should be more orange as per the light). During night, they'll be blue again. This happens in enclosed spaces, as well, so outside light isn't touching the particles.

Also, I'm not seeing any light from the colored lamps when loading a save with them already placed. Replacing them will fix it until you reload the world again.

DarianLStephens commented 5 years ago

On the plus side, Fancy Block Particles' torch particles do look correct, and they all respond correctly to lighting, so that's a pretty good workaround.

DarkShadow44 commented 5 years ago

Thanks for the feedback! Saving should work in theory, but there's not much point since I'm reworking the saving part as well. I'll make sure to test this before the release though!

DarianLStephens commented 5 years ago

It may have something to do with them being powered by a redstone torch next to them, since other colored lights work just fine when loading.

DarkShadow44 commented 5 years ago

Ah, that's a valuable detail - I actually never tested redstone lamps, only glowstone. Thanks!

DarianLStephens commented 5 years ago

Ah, I guess I could have been clearer that they were colored redstone lamps rather than just glowstone. Sorry for that, but I'm glad it helps.

DarkShadow44 commented 3 years ago

1.7.10 version is out of date, the rework is written from scratch, so I close this bug.