search

DarkShadow44 / CptsModdingLight

Do What The F*ck You Want To Public License
5 stars 1 forks source link

ELN compatability, question/request #38

Closed Elgh-github closed 4 years ago

Elgh-github commented 4 years ago

Hi! I'm currently developing my own version of ELN, with edits, new blocks, balance changes etc. Is it known why eln's block's textures don't show up correctly? I myself, don't really know how to code, more of just ctrl+c & edit. I was hoping i could make the different types of lights (incandescent, fluorescent, led) slightly different colors, like they are in real life. Also, i want to make the HPS (high pressure sodium) streetlamps, you know, the yellow, orange-ish ones. Is there something like setLightColor() or something like that in the colored light mod, that i can use to set it in the lamps config? Also, you don't have to if you can't/don't want to do it, but if you know what is wrong, can you please try and fix compatibility with eln. Thank you in advance!

Elgh-github commented 4 years ago

Well, after looking at files from the mod, i found this in the file: CLLamp.java

dsddsd

If i put that in the config for one of the lamps, i think it would just give me errors, since eln wouldn't know what to do with that. Maybe the build would even fail, anyway, is that the right way to add color to light.

edit#: I quess i would need to import the required files from the mod. If you can't help me, you of course don't have to. Just asking to see if you know. No pressure :)

DarkShadow44 commented 4 years ago

First off, what is ELN? And what does "lock's textures don't show up correctly" mean? Screenshots are always helpful.

Currently the API for setting light color is disabled, since I'm still working on it. Especially for super bright lights I'm not sure how to best handle that. Also refer to https://github.com/DarkShadow44/CptsModdingLight/issues/30 and https://github.com/DarkShadow44/CptsModdingLight/issues/2. I'll probably add a JSON into this mod to apply colors to lamps of other mods. Then it's easy for everyone to add their own colored lights, and I could add sane defaults for all mods that have custom lamps.

Elgh-github commented 4 years ago

Oh sorry, ELN is Electrical age. For what the textures are like, it's just some gray-ish color. I cannot provide a screenshot today, but if you need it, i'll get you one tomorrow. You can find the problem in the original mod compatability list. Lock's is a typo, it was meant to say block's. Again, sorry for the unclear and kinda bad post. I can wait for the JSON method of adding color. It's easier for everyone.

Elgh-github commented 4 years ago

2019-12-30_12 10 06

Here's the screenshot. If you look at the hotbar, you can see how they should actually look like. This is only with the latest version of light overhaul and electrical age. No other mods.

DarkShadow44 commented 4 years ago

Mind testing with 2.1.2, once it's approved by curse? The hand held blocks should work then, the placed blocks probably not.

Interestingly enough, for me the placed blocks are invisible. Is this too the case for you with 2.1.2?

Elgh-github commented 4 years ago

I downloaded and installed 2.1.2. After loading up the world from the previous screenshot, handheld items do work. The blocks i placed before, looked the same. I placed some new ones too to test it.

2019-12-31_09 52 52

Made a new world, placed some blocks. Some of them are invisible, but it kinda depends on which way I look at them. 2019-12-31_09 56 15 The only difference between these images is, that it is viewed from a different angle. 2019-12-31_09 56 32

Also, some of the invisible one's in the middle picture flash in and out of existence, even when i'm not moving. Pretty weird.

DarkShadow44 commented 4 years ago

Thanks for testing, will take a look at it soon.

Elgh-github commented 4 years ago

No problem, happy to help. Good work on the mod. 👍

DarkShadow44 commented 4 years ago

Update 2.1.4 is released, could you retest once it's approved on curse? The blocks should now render properly.

DarkShadow44 commented 4 years ago

FWIW, if you're curious, the problem was that the mod uses immediate rendering. When it tries to set the textures, my shaders don't notice and just draw... something. Solved the issue by rerouting all texture-setting through my mod.

Elgh-github commented 4 years ago

Yeah, i'll re-test in the morning. It's really late now where i live.

Elgh-github commented 4 years ago

Ok, everything that i had time to test seems to work fine now. Thanks. I'll continue testing after school ends.

Elgh-github commented 4 years ago

After further testing, i have yet to find problems. I'll close this issue now. Keep up the good work.