search

DarkShadow44 / SereneSeasons

Minecraft mod that adds seasons with changing colors, temperature shifting, and more!
https://minecraft.curseforge.com/projects/serene-seasons
Other
14 stars 6 forks source link

bugs that I saw through my testing #15

Open KibaTheBarbarian opened 4 years ago

KibaTheBarbarian commented 4 years ago

1.If I grow a tree out of season by using bone meal still it grows but it glitches out and I have to re-log to fix it 2.By the looks of it, tick updating can forcefully grow plants out-of-season like using extra utility watering can

  1. The tab-completion option for /ss setseason has a typo: early_autum
  2. Often the game crashes when I load a SP world due to foliage coloring, but the game loads on the second attempt: https://pastebin.com/zDjQEXSS
DarkShadow44 commented 4 years ago

I fixed the typo. However, I can't reproduce the other issues.

1 & 2) Are you using the latest version, compiled from source? If so, how do I reproduce the issues?

4) Do you know how to reproduce? Could be a race-condition, but I'd need a way to at least test for it semi-reliably.

KibaTheBarbarian commented 4 years ago

https://youtu.be/6IJ2fquT6CM the bugs https://youtu.be/5-nhmduwvS8

DarkShadow44 commented 4 years ago

I managed to reproduce the tree growing issue, seems to only affect harvestcraft trees. Split into https://github.com/DarkShadow44/SereneSeasons/issues/16

Still can't reproduce the other issues. Please try to give exact steps so I can reproduce it. Also, make sure to compile the latest version from source.

ORANG4 commented 4 years ago

I managed to reproduce the tree growing issue, seems to only affect harvestcraft trees. Split into #16

Still can't reproduce the other issues. Please try to give exact steps so I can reproduce it. Also, make sure to compile the latest version from source.

I found the same tree growing issue with Biomes o Plenty trees. (modpack with SS and BoP only) Could you please make SS to load before BoP?

DarkShadow44 commented 4 years ago

Sorry for the late replay, I fixed the BOP tree growing issue. If you know more affected mods, please open a new issue for me to easier see it.

DarkShadow44 commented 4 years ago

@KibaTheBarbarian Need more info to reproduce the other issues.

KibaTheBarbarian commented 4 years ago

just use extra utilities watering can on a plant out of season

KibaTheBarbarian commented 4 years ago

i saw the crash Class transformer null safety: found misbehaving transformers: sereneseasons.asm.transformer.WeatherTransformer(sereneseasons.asm.transformer.WeatherTransformer@52ed1508) crashed with java.lang.NullPointerException(null),sereneseasons.asm.transformer.ColorTransformer(sereneseasons.asm.transformer.ColorTransformer@39c674c7) crashed with java.lang.NullPointerException(null)

DarkShadow44 commented 4 years ago

When did you get that crash? What did you do exactly? Is there a log for that crash?

KibaTheBarbarian commented 4 years ago

ya i got it today https://pastebin.com/42VizKia during the scenario is raining one part and snowing in the other if join the discord i can help you fine the bug

makamys commented 4 years ago

If you don't mind me hijacking this issue, I have some observations I can share that might be helpful:

  1. It rains in deserts in MID_WET seasons (e.g. early spring), which shouldn't happen. The reason for this is that only deserty biomes use tropical seasons. Isn't this a mistake?
  2. In ColorTransformer and WeatherTransformer, a possibly null value is passed to the constructor of ClassReader, which can cause a NPE. I'm not sure if this causes any problems, but I've seen server crash logs that may have been caused by it. It would be safer to check if bytes is null first, and return null if it is.
DarkShadow44 commented 4 years ago

@makamys I'd prefer separate issues. Please see #17.