DarkShadow44 / SereneSeasons

Minecraft mod that adds seasons with changing colors, temperature shifting, and more!
https://minecraft.curseforge.com/projects/serene-seasons
Other
14 stars 6 forks source link

SereneTweaks support for 1.7.10 #27

Closed DarkShadow44 closed 1 year ago

DarkShadow44 commented 2 years ago

See https://github.com/FIREdog5/SereneTweaks/issues/8

DarkShadow44 commented 2 years ago

To build just "gradlew jar" should be enough. I already have an untested port pushed, maybe you can test that.

danielrossyamitrano commented 2 years ago

So far, so good. I started a new Large Biomes world sucessfully and after an hour of play I haven't had any problems (I haven't crafted the clock yet) related to the mod. I have one question tho: this backdrop doesn't come with Serene Tweeks installed, isn't it?

DarkShadow44 commented 2 years ago

It should come with SereneTweaks, though I didn't test whether it actually works ;)

danielrossyamitrano commented 2 years ago

Oh, I see. That is what you want me to test, right?

danielrossyamitrano commented 2 years ago

2022-07-16_00 34 34 I have almost every kind of tree planted around my house (except acacia) and I found that the Spruce Trees' foliage doesn't seem to be changing its colors whereas the Birch trees (pictured) as well as the Rubber Trees (not pictured) from Industrial Craft 2 experimental do change.

I don't know if that's a bug or a feature since Spruce trees grow normally in the extreme hills biome which is cold by default. And I think the real trees of that variant don't loose their leaves in autum. Is that correct?

DarkShadow44 commented 2 years ago

Yes, Spruce is unaffected by seasons, always has been.

danielrossyamitrano commented 2 years ago

Oh, I see. That's what I thought.

danielrossyamitrano commented 2 years ago

A few shots from the Plains biome my home is, at nightime. I walked a few chunks away and the snowing cotinued. https://ibb.co/4d3JhYm https://ibb.co/Mk0ss35 https://ibb.co/qsV0JTm https://ibb.co/0D3ypZ6 https://ibb.co/74dtX6x https://ibb.co/9WH70M6

And finally four shots at daytime from high above a platform. https://ibb.co/r7LzR66 https://ibb.co/smVKtk9 https://ibb.co/kxkMPmB https://ibb.co/KmkrD5H

DarkShadow44 commented 2 years ago

Of course it continues snowing, it's still winter. SereneTweaks would make it so that there's already snow on the floor when you visit a chunk in winter where you haven't been for a while.

danielrossyamitrano commented 2 years ago

I about 7000 meters away from my home, when I think winter ended (I didn't have the clock with me) and all the chunks around me started glitching out of existence. I tried to fix the problem by tweeking the render distance, turning off fancy graphics and so on, but nothing happened. The problem only fixed itself when I removed SereneSeasons from the mods folder, but the snow left by winter is still here.

danielrossyamitrano commented 2 years ago

Well, no. It seems to be a problem with other mod since I restarted a world without sereneseasons and the glitch I mentioned still happens.

DarianLStephens commented 2 years ago

Any chance you might be able to privately share a compiled version with me on Discord or something? I could test this in a minute.

DarkShadow44 commented 2 years ago

Sure, just send your discord tag to my email (visible in my github profile)

DarianLStephens commented 1 year ago

Having run a version of it for a bit on a server, I haven't seen this work. The closest I think I've seen is single blocks of ice in water. Maybe it's only working on the first block in a chunk?

DarkShadow44 commented 1 year ago

That shouldn't happen, although I never tested it in detail.

DarianLStephens commented 1 year ago

It's hard to find good screenshots of it, but you can see a single snow block in the center of all these chunks in JourneyMap: image

DarkShadow44 commented 1 year ago

Sorry for the super late solution, but it should be fixed in Fixed in 1.3.0. Please retest, and report back if there's issues.

DarianLStephens commented 1 year ago

I'm not 100% sure it's SereneSeasons, but I keep seeing patterns like this in the SereneTweaks-generated snow, where it causes plant generation to fail somehow, being cut off at chunk borders. 2023-05-15_05 58 13 It only seems to happen in freshly-generated chunks. Maybe the snow is generating too fast or something? Here's an example in another world: 2023-05-14_06 15 00 2023-05-14_06 15 27

DarkShadow44 commented 1 year ago

I'm not exactly sure what the problem is... Can you please open a new issue for that, and show the problem from normal first person view?

DarkShadow44 commented 1 year ago

I did a few changes, now it uses world time over real system time, and chunks really need to be unloaded for the effect to work. Before it sometimes didn't properly update the time, so that could have had that result... Could you please retest?

danielrossyamitrano commented 1 year ago

I did a few changes, now it uses world time over real system time, and chunks really need to be unloaded for the effect to work. Before it sometimes didn't properly update the time, so that could have had that result... Could you please retest?

I will do it shortly. Thanks.

danielrossyamitrano commented 1 year ago

Well, I don't know why this is closed, but I comment anyway. I don't know if it is a bug or a feature, but the duration of the day/night cycle seems to be the same for the standard minecraft experience. When I commented that I would be nice to have the SereneTweek features in 1.7.10, I was refferering precisely about that. On a later try, I changed the "Day Duration" setting on "time settings" to 1728000 ticks (which is 24 real time hours) and when I tested it, I noticed that it doesn't work as SereneTweeks does. If I start a new game now (18:10) it should be 18:10 in the game, but it's not, and the sun still sets and rises normallly.

DarianLStephens commented 1 year ago

I'm pretty sure that setting is only to let you sync SereneSeasons up if you have another mod that affects the day/night cycle's length. I don't see anything on Serene Tweaks' Curse page that mentions the day/night cycle's length.

danielrossyamitrano commented 1 year ago

You are right. I was think of RealSerene, which is another related mod that does that.