DarkShadow44 / SereneSeasons

Minecraft mod that adds seasons with changing colors, temperature shifting, and more!
https://minecraft.curseforge.com/projects/serene-seasons
Other
14 stars 6 forks source link

[Shaders] rain puddles support with serene seasons #32

Closed kotmatross28729 closed 1 year ago

kotmatross28729 commented 1 year ago

Some shaders (eg bsl) have rain puddles. But with serene seasons, in the winter season it snows instead of rain, but there are still rain puddles

https://github.com/DarkShadow44/SereneSeasons/assets/110309314/8ea7bfa6-3b82-4ded-8010-7f6466de4502

DarkShadow44 commented 1 year ago

Not sure I can even fix this. But can you provide the shaders (and shadermod) and everything else I need to reproduce?

kotmatross28729 commented 1 year ago
  1. put BSL_v8.2.03.13d.zip in shaders folder
  2. create the world
  3. set winter
  4. /weather rain
  5. wait
  6. this
kotmatross28729 commented 1 year ago

Basically, to fix this, you need to somehow disable them during the winter season. They can be disabled in the shader files by opening the archive, further along the path shaders\lib\reflections\rainPuddles.glsl and find line 29 val + = texture2D(noisetex, ppos / 128.0 - frametime * 0.005).r * 0.35; after it (that is, instead of the empty line 30) put return val;

It should turn out like this: 1

DarkShadow44 commented 1 year ago

Seems to needs Shader Options -> Materials -> Advanced Materials : ON And possibly another resource pack it says? Anyways, I can't get ripples to work, please tell me what I need to do for ripples to appear.

kotmatross28729 commented 1 year ago

Shader Options -> Materials -> Specular & Reflections -> Rain Reflection : ON (Should be enabled by default)

kotmatross28729 commented 1 year ago

Try pressing "Reset" and enable Advanced Materials (And yet, what I showed above (in the shader files) is needed to disable ripples)

DarkShadow44 commented 1 year ago

Alright, I thought it only happens on water... It works now, and I'm looking into it

DarkShadow44 commented 1 year ago

Should be fixed by d448a17ea700d5054daa19b0cc9894e3d4f5f776. It's a hacky hack, but it works. Please test...

kotmatross28729 commented 1 year ago

Should be fixed by d448a17

Wow, I didn't even think you'd be working on this. But you did! Thank you very much! (I tested it and it works without problems, thanks again!)