DarkSoul1800 / DarkysBatch

Bundle mod for Cookie Clicker, containing new Achievements and Upgrades.
MIT License
2 stars 7 forks source link

Port to new modding API #3

Closed hyoretsu closed 3 years ago

hyoretsu commented 3 years ago

I was having some problems while creating my mod, so I tried (successfully so) porting yours to the new modding API in the meantime since it's been broken for almost 2 months now.

hyoretsu commented 3 years ago

Simply copying each of your mods' code to a single batch file is pretty meh, especially when that complicates the saving/loading process, so I recommend that you keep them as separate mods. At most make it so that the "batch mod" simply loads each of the other two.

hyoretsu commented 3 years ago

Implemented the idea in this issue so that there can be multiple files with fewer code each, though with Webpack instead of Rollup. You can run yarn build or npm run build (in which case you'll need to delete yarn.lock and install dependencies with NPM and change the script in package.json) to merge all the files so you can test it in Cookie Clicker, but I set it to run automatically when you make a commit. It might be a little too organized, but that's a minor issue. Keep in mind that the files you want to use as your releases are in /dist.

Note: in case you don't notice it I made a mistake when setting up the commands to run automatically. It's fixed in d49b54b.

hyoretsu commented 3 years ago

Added your upgrade idea that you commented out. I think it's pretty easier now that we have cps hook.