search

DarkThemeHub / GithubDarkTheme

Dark Theme for Github
GNU General Public License v3.0
53 stars 13 forks source link

Fix draft PR icon red-ness #222

Closed forivall closed 3 years ago

forivall commented 3 years ago

Changes

Not sure if this is the right change. Alternative would be to change the CSS variable --color-text-danger, or changing the selector to .closed.octicon:not(.color-text-secondary)

Screenshots or Gifs

Not dark: Screen Shot 2021-03-29 at 11 34 09 AM

Before: Screen Shot 2021-03-29 at 11 34 25 AM

After: Screen Shot 2021-03-29 at 11 49 28 AM

Screen Shot 2021-03-29 at 11 50 15 AM Screen Shot 2021-03-29 at 11 49 58 AM Screen Shot 2021-03-29 at 11 48 55 AM

Some devtools/css stuff (with js execution paused by pressing f8, so the tooltip stays there): Screen Shot 2021-03-29 at 11 41 13 AM Screen Shot 2021-03-29 at 11 41 54 AM Screen Shot 2021-03-29 at 11 42 04 AM

Snazzie commented 3 years ago

Nice catch!

Root variables would definitely be the prefered way to override if possible since github adopted it "recently", it just makes the theme a bit easier to maintain :P This would also mean we should be removing class name overrides where appropriate, eventually remove a lot of redundent noise :)

Some devtools/css stuff (with js execution paused by pressing f8, so the tooltip stays there):

what tool do you use to pause? this is super handy

forivall commented 3 years ago

The tool to pause is just chrome devtools - just make sure you have the "sources" tab open, and then in the browser, while hovering, hit f8 (im on a mac with an external PC keyboard (which has the fn keys), it should work the same way on windows & linux)