search

DarkWanderer / ClickHouse.Client

.NET client for ClickHouse
MIT License
315 stars 62 forks source link

Please consider providing a strong name for ClickHouse.Client #380

Open osigurdson opened 11 months ago

osigurdson commented 11 months ago

See MSDN discussion here: https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming

DarkWanderer commented 11 months ago

Hi. Thank you for your suggestion - this seems like something relatively straightforward to implement. One point about versioning is slightly unclear to me - the article mentions:

CONSIDER incrementing the assembly version on only major version changes to help users reduce binding redirects, and how often they're updated

I assume you have experience with using strongly signed assemblies. How problematic would it be for users if AssemblyVersion updates with each release like it does now?

osigurdson commented 9 months ago

Hello! I don't have experience with signing assemblies for broad consumption on nuget. I had a look at a few other projects (NodaTime, Log4Net, etc) and they appear to be using the and true in the csproj or within Directory.Build.props. The attribute matches what is on nuget and I believe the AssemblyVersion is getting updated as well. Some examples below.

Log4Net: https://github.com/apache/logging-log4net/blob/master/src/log4net/log4net.csproj

NodaTime: https://github.com/nodatime/nodatime/blob/main/Directory.Build.props