DarkWanderer / Elite-Log-Agent

Lightweight, non-intrusive data uploader for Elite Dangerous
MIT License
43 stars 12 forks source link

Error procesing update. #24

Closed 3navis closed 6 years ago

3navis commented 6 years ago

error

DarkWanderer commented 6 years ago

Thank you for your report.

Looks like Json.Net can't parse Statistics event for some reason. Would you be able to attach (or send me privately) a couple of latest E:D log files, so I can take a closer look?

(wrong button - didn't mean to close)

YinYin-Falcon commented 6 years ago

Similar problem here:

image

5 latest logs:

Journal.180812130523.01.log Journal.180726183818.01.log Journal.180723150336.01.log Journal.180521153811.01.log Journal.180817124009.01.log

DarkWanderer commented 6 years ago

Hi @YinYin-Falcon,

Thanks for your report and especially for attached files. I'm in a trip until this weekend but will definitely take a look then.

Note it seems to be a different root cause than the error in OP, but definitely needs fixing too.

DarkWanderer commented 6 years ago

@YinYin-Falcon current release contains a few improvements around data parsing - please let me know if that helped

YinYin-Falcon commented 6 years ago

Nope, I'm getting the exact same error.

3navis commented 6 years ago

Journal.180910140949.01.log Journal.180910075707.01.log Journal.180910071417.01.log

DarkWanderer commented 6 years ago

Hi. Thank you very much for your reports.

Curiously, I cannot reproduce this at all. The journal files are well-formed and are parsed without issues or exceptions. I have tried switching locale, but that didn't help a little bit - everything still works fine.

There must be something I am missing when trying to reproduce. It's almost as if something is changing the file at the same time the program tries to read it. Do you guys run EliteLogAgent in parallel with other log-parsing software? (EDMC, EDDI, etc.) If yes, can you try to turn it off temporarily and see if that helps?

YinYin-Falcon commented 6 years ago

No, I didn't even run E:D when I tested this. I'm not getting errors on the current build anymore. (I've got new logs since last time)

But I also don't see any logs appearing on EDSM after clicking upload.

And the API key validates successfully with the wrong combat rank (mostly harmless).

DarkWanderer commented 6 years ago

Great - sounds like the original error is fixed then.

As for EDSM, if the server returns a combat rank (mostly harmless), it means that the API key is correct (but for wrong account?). Can you try:

  1. Regenerating API key & putting it into the app (don't forget to press 'Apply' and/or 'OK')
  2. Restarting the app (just in case)
  3. Pressing "import latest data"
  4. Waiting for 90 seconds
  5. Opening EDSM and checking for data?

That should account for both load-reducing mechanisms triggering and potentially incorrect key

If that fails - please attach ELA log (%appdata%\EliteLogAgent\Log), I'll take a closer look

DarkWanderer commented 6 years ago

@3navis does the issue reproduce for you in latest release?

3navis commented 6 years ago

yes, release is 6.3.282

Validate EDSM return Success, combat rank: Dangerous Validate INARA return Success, Inara ID: 62505 Upload last 5 files, Error ,,,, line 12 position 1839

Can I know exactly what file he is trying to read? In what directory are you looking for the logs? regards,

DarkWanderer commented 6 years ago

The "import latest" function takes 5 last .log files (as sorted by name), plus whatever is in .json files (commodities, outfitting, shipyard etc.). The data is taken from "saved games" Windows dir - usually it's C:\Users\<username>\Saved Games\Frontier Developments\Elite Dangerous. I have no idea which exactly file causes this issue - but given that it's mentioning TG_ENCOUNTERS, it's most probably the journal file (.log)

Can you zip & attach the whole log dir? That'd be easier to look at (I'll delete it afterwards)

3navis commented 6 years ago

Hello, thank you very much for the information. when I have ordered by name they have appeared log files of the Beta, in front of the correct ones. "JournalBeta.180126075403.01.log" (7 files) I have removed these files and the problem has been solved,

YinYin-Falcon commented 6 years ago

I have nowhere I could press "import latest data". (only upload last 5 files via all plugins)

A new API key and restarting things itself didn't change the situation.

Could the JournalBeta logs be causing this issue? I have no plans to delete them.

DarkWanderer commented 6 years ago

@YinYin-Falcon That is what I meant, sorry for not being clear. Yes, JournalBeta are likely causing the issue here. No need to delete JournalBeta files, I will fix them in scope of #35. ETA this weekend.

DarkWanderer commented 6 years ago

@YinYin-Falcon Latest release should be working fine with JournalBeta files present. Could you please confirm?

YinYin-Falcon commented 6 years ago

Can confrim.

Is there a way to upload more than the last 5 logs? There is a bit of a gap for me.

DarkWanderer commented 6 years ago

Splendid - thanks for the help in debugging to both of you.

Is there a way to upload more than the last 5 logs?

There is no way in the program itself at the moment. You can go one of following ways:

I will think about allowing a wider range in the app itself - need to make sure it's not abused