Incorrect StarSystem is sometimes reported with Scan event

DarkWanderer / Elite-Log-Agent

Lightweight, non-intrusive data uploader for Elite Dangerous

MIT License

43 stars 12 forks source link

Incorrect StarSystem is sometimes reported with Scan event #70

Closed DarkWanderer closed 4 years ago

DarkWanderer commented 5 years ago

Ref. mismatch tracking sheet - it seems occasionally FsdJump events are skipped in PlayerStateRecorder somehow

DarkWanderer commented 5 years ago

Anthor reported this still sometimes happens with FSS events, example: { _shipId: 0, _systemName: Byeia Eurk SF-G b24-20, Count: 1, event: FSSAllBodiesFound, SystemAddress: ********, SystemName: Plaa Aescs WN-C a68-0, timestamp: 2019-01-24 06:23:06 } I need to add more robustness into EDSM enrichment and parsing error handling

DarkWanderer commented 5 years ago

[x] Apply a hotfix to avoid EDSM enrichment overwriting stuff with clearly incorrect values
[ ] Make serialization errors softer - FsdJump deserialization problems should not cause skipping of that event
[ ] Add custom serializers to events which have backward-incompatible changes (to ensure whole timeline can be deserialized)
[ ] Revisit serialization unit test (LogEventConverterTests.cs) to remove temporary kludges

DarkWanderer commented 4 years ago

Judging by stats for latest version, this has been fixed