Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
740 stars 83 forks source link

Follow the system theme #1

Closed julianfairfax closed 1 year ago

julianfairfax commented 1 year ago

I see F-Droid inclusion is planned and I'm excited. The app should also be able to follow the system theme. Imv the colours in the dark mode are too bright and not as pastel as those in light mode. But this is probably subjective.

Darkempire78 commented 1 year ago

Fdroid accepted OpenCalc , but we have to wait some hours or days before Fdroid repos update.

Darkempire78 commented 1 year ago

You can suggest new hex code to change the colors, maybe it will be more beautiful (I'm not a design expert 🤣)

julianfairfax commented 1 year ago

You can suggest new hex code to change the colors, maybe it will be more beautiful (I'm not a design expert rofl)

What about #88bb91, #85b5d2, and #bf879d? An interpretation of the light colours for dark mode, from a fellow person who is not a design expert. F-Droid would have to update the app (even though they haven't built it yet) if there are changes btw.

Looks like this: 1

julianfairfax commented 1 year ago

It also seems the theme selection doesn't persist through app closing and reopenings. (Fixed in latest version actually!) And no Material You

Darkempire78 commented 1 year ago

Follow system theme added in the v1.1.0

Darkempire78 commented 1 year ago

You can open a new issue for Material You support if you want or an other thing ^^

Darkempire78 commented 1 year ago

@julianfairfax For the colors, perhaps that we should make a poll or something like that idk ?

julianfairfax commented 1 year ago

@julianfairfax For the colors, perhaps that we should make a poll or something like that idk ?

Idk. Where we doing the poll? How many answers we want? What are the options? How much time we allocating?

julianfairfax commented 1 year ago

@Darkempire78 Perhaps #5fa36b, #6791aa, and #95556e would be better? More legible

image 2

Maybe the top background colour should also be changed to be more legible? Something like #383737?

image 3

Darkempire78 commented 1 year ago

It looks nice 🤔

julianfairfax commented 1 year ago

It looks nice thinking

I see you have a Discord server. i don't use Discord but i suppose you could do a poll there if you want. I'm no designer either and this is your app. But in my humble opinion I think this colour change would be nice to see. Thanks for developing this app!

Leif-W commented 1 year ago

As far as the proposed pastels on dark mode, they are all too bright, washed out. In dark mode, probably nothing should be brighter than #7f7f7f, considerably less. I'm no design expert, but this is basic common sense. Dark mode is often used in the dark, because bright colors hurt the eyes.