Closed lefterisgar closed 1 year ago
It's not still perfect, sometimes there are some crashes
Thanks for taking the time to perfect this PR! Are there still crashes after your last commit?
Thanks for taking the time to perfect this PR! Are there still crashes after your last commit?
I just forgot withContext(Dispatchers.Main) {}
Maybe "syntax error" is more explanatory than "format error"?
Maybe "syntax error" is more explanatory than "format error"?
You are right, I change that
Could you update the greek translation please ? After that I will merge it
Could you update the greek translation please ? After that I will merge it
Yes, of course!
I see this line: if (x.isNaN()) format_error = true
is used multiple times. Can this only be on top and apply to all cases?
I see this line:
if (x.isNaN()) format_error = true
is used multiple times. Can this only be on top and apply to all cases?
Yes I fixed that
Thank you so much for your pull request :)
Thanks for the awesome project! :)
Hello and congratulations for releasing v2 of this awesome app! I've made a few improvements to it. Let me know if you want me to change something.
Here is a list of what this PR fixes: