Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
740 stars 83 forks source link

Multiple improvements #158

Closed lefterisgar closed 1 year ago

lefterisgar commented 1 year ago

Hello and congratulations for releasing v2 of this awesome app! I've made a few improvements to it. Let me know if you want me to change something.

Here is a list of what this PR fixes:

Darkempire78 commented 1 year ago

It's not still perfect, sometimes there are some crashes

lefterisgar commented 1 year ago

Thanks for taking the time to perfect this PR! Are there still crashes after your last commit?

Darkempire78 commented 1 year ago

Thanks for taking the time to perfect this PR! Are there still crashes after your last commit?

I just forgot withContext(Dispatchers.Main) {}

lefterisgar commented 1 year ago

Maybe "syntax error" is more explanatory than "format error"?

Darkempire78 commented 1 year ago

Maybe "syntax error" is more explanatory than "format error"?

You are right, I change that

Darkempire78 commented 1 year ago

Could you update the greek translation please ? After that I will merge it

lefterisgar commented 1 year ago

Could you update the greek translation please ? After that I will merge it

Yes, of course!

lefterisgar commented 1 year ago

I see this line: if (x.isNaN()) format_error = true is used multiple times. Can this only be on top and apply to all cases?

Darkempire78 commented 1 year ago

I see this line: if (x.isNaN()) format_error = true is used multiple times. Can this only be on top and apply to all cases?

Yes I fixed that

Darkempire78 commented 1 year ago

Thank you so much for your pull request :)

lefterisgar commented 1 year ago

Thanks for the awesome project! :)