Closed lefterisgar closed 1 year ago
Update: Breaks light theme
DO NOT MERGE, I have fixed it and will push it today.
Works well! But the color is terrible x)
I do not know if this color is perfect, but it looks better I think (it would be nice to have a design expert look at the project one day lmao)
Update: Breaks light theme
DO NOT MERGE, I have fixed it and will push it today.
Sure, I saw the bug, ping me when it is good
Works well! But the color is terrible x)
I have to agree but as it was called "default error color", I thought it adhered to the Material You guidelines.
It would be nice to have a design expert look at the project one day lmao
Haha, I hope so! :) By the way, isn't the UI inspired by Google's calculator? (they look identical IMO)
I messed a few things up while rebasing. Could you please cherry-pick or send me the hash of the commit where you changed the color?
I messed a few things up while rebasing. Could you please cherry-pick or send me the hash of the commit where you changed the color?
768e270a45361475bb40be1a2e31eba6c159bfed
I think we are ready to merge.
Update: Managed to get apk size from 4.5MB to just under 2MB.
Update: Managed to get apk size from 4.5MB to just under 2MB.
Thank for that, for the next time open another pull request if it is not related to the aim of the current pull request please :)
I think that adding some color can greatly improve the overall UX of the app. This PR changes the text color to red if an error occurs and then resets it if a change is detected. Also adds another improvements, like removing deprecated methods and cleanup.