search

Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
740 stars 83 forks source link

Outdated and inconsistent dialogs in settings #299

Open meenbeese opened 9 months ago

meenbeese commented 9 months ago

Describe the bug Some of the dialog menus used in the settings are outdated and look out of place. They don't follow the Material You color palette and instead have a Material 2 design.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Number of decimal places' or 'Results saved in history'
  3. See the old dialog/fragment

Expected behavior They should be similar to the dialog menu used for the 'Theme'.

Screenshots/videos Screenshot_20230728_211853_Calculator_1 Screenshot_20230728_211900_Calculator_1

Smartphone (please complete the following information):

Additional context I saw this issue in only 2 of the 3 menus found in the app which are mentioned above.

Darkempire78 commented 6 months ago

I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299 It's now using the material design 3, but not with the good colors

meenbeese commented 6 months ago

I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299

It's now using the material design 3, but not with the good colors

Thanks, it is still a clear improvement.

inson1 commented 6 months ago

@Darkempire78 you could also add screenshots. It could save few minutes.

meenbeese commented 6 months ago

@Darkempire78 you could also add screenshots. You could save as few minutes.

Please be respectful. @Darkempire78 is doing free and volunteer work on an open source project. He literally has zero obligations to you, and if you want luxury treatment you better be donating him a handsome amount before speaking.

inson1 commented 6 months ago

@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.

studio64_xYuFmQhDkV studio64_Et08wDp60y studio64_dqaKN2vNi0 studio64_uAsL5O6v32

meenbeese commented 6 months ago

@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.

I'm sorry if I sounded harsh, but I see this attitude in many people who are new to open source. It only demotivates the developer and harms the community. Your original comment sounded very condescending, so thanks for modifying it @inson1.

inson1 commented 6 months ago

@meenbeese To be clear I wanted to add the screenshots when I added the first comment. So that could changed the meaning. I didnt change the comment to be nicer, it just souded better. I didnt meant to sound condescending, its just nice when people share also the screenshots. So I want luxury treatmeant for everyone from everyone xD People can forget and that is ok.