fix crash when recreating landscape main activity

Darkempire78 / OpenCalc

A simple and beautiful calculator for Android

GNU General Public License v3.0

737 stars 82 forks source link

fix crash when recreating landscape main activity #343

Closed danthe1st closed 6 months ago

danthe1st commented 6 months ago

Fixes #303

The layout/activity_main.xml uses Button while layout-land/activity_main.xml and layout-sw720p-land use ImageButton for some of the buttons.

This issue was described in this Stack Overflow answer.

This PR changes layout-land/activity_main.xml and layout-sw720p-land to use Button instead of ImageButton.

I wasn't able to test the changes to layout-sw720p-land.

danthe1st commented 6 months ago

The added tests require an emulator/connected device. This PR does not add any CI functionality.

Darkempire78 commented 6 months ago

It works well on my Pixel 2, it should be good, thank you!