Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
727 stars 81 forks source link

Comma seperator not working inside parenthesis #403

Closed Heikrana closed 1 month ago

Heikrana commented 3 months ago

Describe the bug Comma at every thousandth place not coming inside parenthesis but only 1 comma no matter how many zeros. This happens when you add a lot of parenthesis.

To Reproduce Steps to reproduce the behavior:

  1. Do some calculation with parenthesis and inside as well.
  2. After certain number of parenthesis comma seperator will malfunction.

Expected behavior Comma seperator should work properly.

Screenshots/videos Screenshot_20240112_202404_Calculator

Smartphone:

Additional context It might be related to locality as in Indian number system, 1st comma seperator comes at 1000th place and then at every 100th place.

muryno commented 3 months ago

PR fix is raised for this here. https://github.com/Darkempire78/OpenCalc/pull/416

Darkempire78 commented 1 month ago

fixed