Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
727 stars 81 forks source link

Several buttons are not labeled properly #405

Open PatchMixolydic opened 3 months ago

PatchMixolydic commented 3 months ago

Describe the bug The ellipses menu, more buttons button, and exponentiation button do not have accessible labels, rendering them inaccessible to screen reader users. Also, some of the scientific buttons just use their visual label, causing them to be misread (eg. "ln" is announced as "lane" instead of "L N" or "natural log").

To Reproduce Steps to reproduce the behavior:

  1. Enable TalkBack
  2. Open OpenCalc
  3. Tap and hold, then drag around the calculator
  4. Observe that some buttons are not labeled correctly

Expected behavior These buttons should be labeled accurately.

Screenshots/videos (I tried recording a video, but it didn't seem to pick up TalkBack ^^;)

Smartphone (please complete the following information):

inson1 commented 3 months ago

I think its feature request not a bug, OpenCalc doesnt yet support talkback, after its done its should be added to feature list

inson1 commented 3 months ago

So we should add contentDescription attribute to all elements that dont work and add translations of those descriptions ( or maybe to all?) https://developer.android.com/guide/topics/ui/accessibility/principles#label-elements https://stackoverflow.com/questions/18516516/should-content-description-be-in-multiple-language

Imagebuttons dont work sections dont work, because they use capitalized characters + I would add "section" to their name (in description) DEG, RAD, INV dont work because they use capitalized characters

Darkempire78 commented 1 month ago

Open a Pull request for this please