Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
727 stars 81 forks source link

fix: Implement BroadcastReceiver to start activity from TileService #424

Open muryno opened 2 months ago

muryno commented 2 months ago

Fixes #415

Refactor: Use BroadcastReceiver for TileService activity launch

Switched to BroadcastReceiver approach for starting an activity from a TileService due to its compatibility with Android's security guidelines, ensuring a smooth and non-intrusive user experience. An alternative could be using notifications, but they may not prompt immediate action as effectively.

The notification approach, while less intrusive, may not be ideal for all scenarios, especially if immediate action or interaction is required from the user. Notifications can be easily missed or ignored, leading to a less responsive or immediate user experience. More guide on this Android developer guide

muryno commented 2 months ago

Fixes: #415

inson1 commented 2 months ago

@muryno btw you need to add it to the op post, so the issue linked to the PR :)

muryno commented 2 months ago

@muryno btw you need to add it to the op post, so the issue linked to the PR :)

what is OP @inson1 😊

inson1 commented 2 months ago

@muryno original post - I meant that it should be in first post, writting it in comment doesnt link the issue and the pr together

muryno commented 2 months ago

@muryno original post - I meant that it should be in first post, writting it in comment doesnt link the issue and the pr together

Thank you @inson1 I already did that, was posted in both 😊

inson1 commented 2 months ago

@muryno but its still not linked - I meant in first post in this PR, sorry for being clear :) https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue your chrome_lTQE0JQ03w how it should look like (but it should be linked only with one) chrome_tS8c3Gyyf5

Darkempire78 commented 1 month ago

There is a conflict @muryno

muryno commented 1 month ago

There is a conflict @muryno

now resolved

Darkempire78 commented 1 month ago

I'm not able to launch OpenCalc from Tiles 🤔

muryno commented 1 month ago

Tiles will check this

muryno commented 1 month ago

@Darkempire78 now updated from using broadcast receiver and sticking with google documentation TileService